Calendar page #37
Calendar page #37
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
szép munka! jól néz ki, meg nagyon ügyes is a custom render
mobilon még kicsit szétcsűszik, lehetne ott kisebb a margó pl, meg a napokból talán csak a kezdő betűk látszódjanak
majd nem fogod tudni még merge-ni, mert vannak conflict-ok, ezeket szerintem úgy a legegyszerűbb feloldani, hogy előbb a master-t mergeled bele ebbe, itt lokálisan feloldod a konfliktokat, felpusholod és utána mergeled ezt vissza a masterbe
nice job!
|
|
||
| import { styles } from '@/components/calendarStyles'; | ||
|
|
||
| // Segédfüggvények |
|
|
||
| // Calendar komponens | ||
| const Calendar: React.FC = () => { | ||
| const [currentMonth, setCurrentMonth] = useState(7); // Augusztus |
There was a problem hiding this comment.
This should be dynamic as well, we don't want to manually update the month and the year every time it changes :D
Consider using something like const currentDate = new date() and please get the month and year from this one
| }; | ||
|
|
||
| window.addEventListener('resize', handleResize); | ||
| handleResize(); // Csak egyszer hívjuk meg, amikor a komponens betöltődik |
There was a problem hiding this comment.
this comment is a bit misleading, it is called in case of the resize event as well, so please remove it
There was a problem hiding this comment.
Nice work! 😄
I left some comments, and as Máté said, please resolve the merge conflicts, it is a bit hard to see what the new code in the PR is.
The mobile view will need some upgrades too, but be careful with styles like this:
width: '91.666667%'
It's hard to work with, try using full values or margins, or you can check out the calculate() function for widths and heights.
I'd avoid using Hungarian comments in the code, also we don't have to add a comment to every single line. Use comments when it helps to understand the code or it has some additional information to the code. Also don't use comments to mark different parts of a file, if it belongs there then usually no comments are needed, but if it doesn't then it should probably be in a different file.
Otherwise, it looks nice, keep up the good work! 🔥
Working calendar, only backend is left to do