-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EnOcean ESP2 protocol support #123
base: master
Are you sure you want to change the base?
Conversation
In general this looks like a good base, the only big issue for me is that there's no backwards compatibility. Also the common base should define This would be a great addition, as the Eltako devices seem very good. Another thing to consider is that can we just leave out passing the version to Of course hardware testing is required, are there any volunteers for that? |
@kipe Thanks for the review. I will adjust the suggested change with the Packet to remain backward compatible. For the idea to resolve the protocol version dynamically: Yesterday I tried to test the ESP2 protocol implementation with my hardware. But as I'm using a Wago 750-650 controller which integrated enocean over modbus I had to do some adjustments within hass as well. Would be great if someone having a Eltako device could test the implementation as well. |
@kipe I just rethought your suggested solution and see a different problem with it. I.e. in the hass enocean integration a type check to RadioPacket exists. If I now would adjust the naming the default names reflect ESP3 protocol and we move base logic to i.e. a BaseRadioPacket, those instance checks wouldn't be compatible to ESP2 either. |
@toggm Yeah, the target should be that no changes are required for ESP3. Changes for ESP2 support on programs using this library would be fine. In practice this is shown (imo), if no changes are requirered to the tests or the current examples. |
@kipe I've now adjusted the implementation, you might have a look again. Reverted changes in tests and examples to stay backward compatible. |
@Stoney49th can you maybe do a hardware testing? |
@toggm @kipe What would be required for the test? I'm pretty busy at the moment, but maybe I can do it on one of the coming weekends... Edit: |
@Stoney49th That would be great! @kipe What do you think, what kind of hardware tests are sufficient to proof the implementation works for most of the devices? |
Any progress on this? |
I'm also interested in ESP2 support to control Eltako 14 controllers. I will test this evening if I can make it work in home assistant and my custom component. I see however a limitation : the communicator can only handle one type of protocol at a time : either ESP2 or ESP3 as it is a parameter of the communicator constructor. |
Hi @vincentdieltiens Feel free to further improve this implementation. |
After reading discussion in #72 I followed a different approach to integrate enocean esp2 protocol messages.
Based on the work of stoney, re-used from the open PR https://github.com/kipe/enocean/pull/78/files#diff-bcf3908433bf40bcb17727cba4377f97e937a7bbddea6d871d3de521b28607cc
As I don't have an standalone enocean controller I'm not able to test the implementation. Would be great if someone with a controller could do the testing and provide me protocol examples so I could extend the PR with test cases.