chore(build)!: fix build on non-windows machines #302
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Working on Linux, I had to do a few things to get this branch to build successfully.
yarn.lock
and thepackage.json
.live-server
's latest version also hadCRLF
endings, which yarn doesn't like at all, causing build failurespython
on Linux is the legacypython2
, which is no longer installed by defaultcopyfiles.py
did not copy files for me. This might be due to the change in 3.Changes
LF
python
on windows andpython3
on other systems. I wasn't able to test this on windows, so please give it a try before merging! If it doesn't work, I think leaving python out of the equation and using the old JS copyfiles or the webpack copy files plugin would be a better approach..tsx
files and created directories if they didn't exist yetAdditional comments
I marked this as breaking because it could potentially break Windows system builds