Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebranding of Xplorer #173

Merged
merged 88 commits into from
Nov 21, 2021
Merged

Rebranding of Xplorer #173

merged 88 commits into from
Nov 21, 2021

Conversation

kimlimjustin
Copy link
Owner

@kimlimjustin kimlimjustin commented Nov 20, 2021

Motivation

#171

Changes

  • Remove all dependencies related to Electron
  • Add Tauri dependencies
  • Reimplement all code to use Rust as the backend for file operation
  • Allow previewing almost all programming languages with syntax highlighting
  • Improve file type determination performance (x3 faster) (33ee1ac)
  • Improve open directory performance
  • Improve memory usage (won't consume as much as the previous release)
  • Decrease the size of the installer
    • Windows Installer from 67.2 MB to 5.75 MB (decrease up to 91.44 percent)
    • Deb Installer from 68.8 MB to 7.57 MB (decrease up to 90 percent)
    • Dmg Installer from 87.6 MB to 5 MB (decrease up to 94.29 percent)
  • Fix sidebar favorites not sync with home page favorites bug
  • Add ability to continue the previous session on startup
  • Add ability to change Fonts, Window Transparency, Frame style, and many more
  • Improve Xplorer layout
  • Introduce a new icon
  • Improve locales
  • Update docs
  • Improve lazy load thumbnail algorithm
  • Add more tests
  • Improve calculate folder's size speed (even faster than windows' default file explorer)
  • Remove monorepo setup and temporarily remove theme customization support as it gives security concerns (resolve Current Implementation of Theme Plugin can Cause Critical Security Concern #157) (will be added back in the future)
  • Add default sorting algorithm for specific folders
  • Improve update theme performance
  • Update icons and file type library
  • Add go to parent directory navigation.

and so on...

Performance

Tested on i7-9700 32GB

Before After
First startup ∼ 1.52 s ∼ 1.28 s
Speed on opening material icon folder ∼0.5 s ~1.5s
Memory used on opening material icon folder 284 MB 220 MB
RAM usage stability Not Stable More Stable

Related

Some issues introduced:

(will be fixed in the future release)

  • High amount of memory needed to listen to drive changes
  • Current approach to extract exe icon is by calling ps1 files underneath the hood
  • xplorer://Trash is not supported on macOS

@vercel
Copy link

vercel bot commented Nov 20, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/kimlimjustin/xplorer/5LQxf2ggVuMaBvQbGGEk3EirxaM5
✅ Preview: https://xplorer-git-rebrand-kimlimjustin.vercel.app

Copy link
Contributor

@stanleyowen stanleyowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Love it really much. However I notice that the maximize button doesn't work appropriately, can you confirm it?

@stanleyowen stanleyowen added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 20, 2021
@kimlimjustin kimlimjustin added All platform Issues on all platform dependencies Pull requests that update a dependency file performance labels Nov 20, 2021
@im-coder-lg
Copy link
Contributor

Been a long time... Does the rebrand still have C++ modules?

@kimlimjustin
Copy link
Owner Author

Been a long time... Does the rebrand still have C++ modules?

Just wanna tag you for the gitpod things haha. The rebrand does not longer contain c++ modules, instead, there're Rust files. Could you please help me handle this?

This is the setup for Linux: https://tauri.studio/en/docs/getting-started/setup-linux

Thanks

@im-coder-lg
Copy link
Contributor

Will do soon 👍🏻

Copy link
Contributor

@stanleyowen stanleyowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivanglushko
Copy link

Curios how Tauri is in production thanks for a great example guys 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
All platform Issues on all platform dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement New feature or request performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Current Implementation of Theme Plugin can Cause Critical Security Concern
4 participants