Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive some more traits for the public api #106

Merged
merged 5 commits into from
Apr 21, 2024

Conversation

omid
Copy link
Contributor

@omid omid commented Apr 21, 2024

Fixes #105

@kilork
Copy link
Owner

kilork commented Apr 21, 2024

Hey, thank you for this contribution. Consider we do not write types by hand, they are generated in openapi.rs. Please, feel free to adjust integration tests to test extra feature variants. Most important here is rc feature.

@omid
Copy link
Contributor Author

omid commented Apr 21, 2024

Thanks. What is openapi.rs?
The one in the examples directory? 🤔🤔

@kilork
Copy link
Owner

kilork commented Apr 21, 2024

Yes, one in examples directory.

@omid
Copy link
Contributor Author

omid commented Apr 21, 2024

So openapi.rs in the examples folder is responsible to generate other files? I'm confused a bit, sorry
If so, why is it in examples of it's not an example?

@omid
Copy link
Contributor Author

omid commented Apr 21, 2024

I read the code more carefully, after these two PRs, I'll try to restructure the code a bit and move it out of examples dir.

@kilork kilork merged commit 0a19aff into kilork:master Apr 21, 2024
1 check passed
@kilork kilork added this to the 24.0.300 milestone Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Derive Clone for all public structs
2 participants