Disable virtual serial port by default #203
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems dangerous to leave this on. If an unprivileged process can write to serial ports, it could send privileged input (like magic SysRq sequences on Linux or a UAC bypass on Windows) or it could act as a keylogger.
|
Yeah, I agree with having the serial port disabled by default. At least for production keyboards. I'm going to keep it enabled at least until I have the API working. Contemplating between rawhid and vendor specific. I know vendor specific will require a small driver (so it should be possible to harden on Windows), not sure about rawhid (which is the preferred interface when doing stuff like this). |
|
That's a good question. I don't know if Windows allows unprivileged processes to send raw HID reports to vendor-defined devices, but I think it might. I have three vendor-defined devices on this PC at the moment and according to WinObj, their device objects allow write access for all users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems dangerous to leave this on. On Windows, at least, an unprivileged process can write to the serial port, and the debug interface could allow it to send privileged input or act as a keylogger.
Edit: Whoops. Somehow I missed the related issue #159 and pull request #160. I still believe the serial port should be off by default, at least until its security can be improved. It's important to note that keyloggers aren't the only threat. Sending fake input through the keyboard could be a problem too.