Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.101.x-prod] SRVLOGIC-390: Adjust cors configuration for the dev profile deployments, and JS and DI deployments #82

Merged
merged 1 commit into from
Sep 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion controllers/profiles/common/properties/managed.go
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ func NewManagedPropertyHandler(workflow *operatorapi.SonataFlow, platform *opera
}

func setDevProfileProperties(props *properties.Properties) {
props.Set(fmt.Sprintf("%%dev.%s", constants.QuarkusDevUICorsEnabled), "false")
props.Set(constants.QuarkusDevUICorsEnabled, "false")
}

// ApplicationManagedProperties immutable default application properties that can be used with any workflow based on Quarkus.
Expand Down
6 changes: 3 additions & 3 deletions controllers/profiles/common/properties/managed_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -470,7 +470,7 @@ func generateJobServiceWorkflowDevProperties() *properties.Properties {
props.Set("kogito.events.processdefinitions.enabled", "false")
props.Set("kogito.events.processinstances.enabled", "false")
props.Set("kogito.events.usertasks.enabled", "false")
props.Set("%dev.quarkus.dev-ui.cors.enabled", "false")
props.Set("quarkus.dev-ui.cors.enabled", "false")
props.Sort()
return props
}
Expand Down Expand Up @@ -523,7 +523,7 @@ func generateDataIndexWorkflowDevProperties() *properties.Properties {
props.Set("kogito.events.processdefinitions.enabled", "false")
props.Set("kogito.events.processinstances.enabled", "false")
props.Set("kogito.events.usertasks.enabled", "false")
props.Set("%dev.quarkus.dev-ui.cors.enabled", "false")
props.Set("quarkus.dev-ui.cors.enabled", "false")
props.Sort()
return props
}
Expand Down Expand Up @@ -581,7 +581,7 @@ func generateDataIndexAndJobServiceWorkflowDevProperties() *properties.Propertie
props.Set("kogito.events.processdefinitions.enabled", "false")
props.Set("kogito.events.processinstances.enabled", "false")
props.Set("kogito.events.usertasks.enabled", "false")
props.Set("%dev.quarkus.dev-ui.cors.enabled", "false")
props.Set("quarkus.dev-ui.cors.enabled", "false")
props.Sort()
return props
}
Expand Down
Loading