Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Blocker for OSL 1.33] Update operator managed persistence extensions to the RHB of Quarkus 3.8.4 and to the OSL version #39

Closed
wants to merge 1 commit into from

Conversation

wmedvede
Copy link
Member

@wmedvede wmedvede commented May 9, 2024

Nothing here yet, but a reminder.

Description of the change:

Motivation for the change:

Checklist

  • Add or Modify a unit test for your change
  • Have you verified that tall the tests are passing?
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@wmedvede wmedvede marked this pull request as ready for review May 9, 2024 15:45
@rgdoliveira
Copy link
Member

@wmedvede is main branch the correct one or you wanted to open against 9.100.x-prod branch?

@wmedvede
Copy link
Member Author

wmedvede commented May 9, 2024

@rgdoliveira @ricardozanini

A small clarification regarding the affected files in this PR:

The source of truth of the change is this file: (here is where we change the versions)

config/manager/controllers_cfg.yaml

Then the following two files are automatically generated when we do
make generate-all. We must update them at the repository, and include in future version changes, but we don't change them manually.

bundle/manifests/sonataflow-operator-controllers-config_v1_configmap.yaml

operator.yaml

Finally, this other two files are changed only for making the number in the test consistent with current quarkus version, but really has no effect other than verifying that the yaml is parsed, etc.

controllers/cfg/controllers_cfg_test.go

controllers/cfg/testdata/controllers-cfg-test.yaml

@wmedvede
Copy link
Member Author

wmedvede commented May 9, 2024

@wmedvede is main branch the correct one or you wanted to open against 9.100.x-prod branch?

good point, my fault 👎 Will close this one and open the correct one.

@wmedvede wmedvede closed this May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants