Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.99.x-prod][SRVLOGIC-228] Investigate why non-dev scenarios now requires JDBC configuration #20

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

wmedvede
Copy link
Member

- kie-kogito-serverless-operator-379: Investigate why non-dev scenarios now requires JDBC configuration (#386)

- Use "latest" image tag and namespaced images generation.

(cherry picked from commit df462a8)

Description of the change:

Motivation for the change:

Checklist

  • Add or Modify a unit test for your change
  • Have you verified that tall the tests are passing?
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

… JDBC configuration

    - kie-kogito-serverless-operator-379: Investigate why non-dev scenarios now requires JDBC configuration (apache#386)

    - Use "latest" image tag and namespaced images generation.

(cherry picked from commit df462a8)
@ricardozanini
Copy link
Member

@wmedvede can you run the make generate-all then make vet fmt? Or since go.work has been deleted those won't work anymore too?

@ricardozanini ricardozanini changed the title SRVLOGIC-SRVLOGIC-228: Investigate why non-dev scenarios now requires JDBC configuration [9.99.x-prod][SRVLOGIC-228] Investigate why non-dev scenarios now requires JDBC configuration Feb 19, 2024
@wmedvede
Copy link
Member Author

@ricardozanini @rgdoliveira

Quick question here

When I try to execute this locally, I can see that for some e2e tests, that uses a sonataflow platform that should install an ephemeral DI and an ephemeral JS, the following images used for each service:

DataIndex:

the following image is picked:
image: >-
registry.redhat.io/openshift-serverless-1-tech-preview/logic-data-index-ephemeral-rhel8:1.32.0

(this now fails, maybe the image is not published yet or my OpenShift local can't pick it, np)

JobsService:

the following image is picked:
image: 'quay.io/kiegroup/kogito-jobs-service-ephemeral-nightly:latest'

And, in the operator code I can see that we have that different images are being picked up intentionally.

https://github.com/kiegroup/kogito-serverless-operator/blob/9.99.x-prod/controllers/platform/services/services.go#L105

https://github.com/kiegroup/kogito-serverless-operator/blob/9.99.x-prod/controllers/platform/services/services.go#L261

@ricardozanini Do we still want this?

@ricardozanini
Copy link
Member

@wmedvede we sure do since JS doesn't have an OSL image just yet.

@wmedvede
Copy link
Member Author

@wmedvede can you run the make generate-all then make vet fmt? Or since go.work has been deleted those won't work anymore too?

They don't work anymore because of the missing go.work

@rgdoliveira rgdoliveira merged commit 7d3cc8d into kiegroup:9.99.x-prod Feb 20, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants