Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.102.x-prod] SRVLOGIC-472: Job service job status change events are not sent in order #112

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

wmedvede
Copy link
Member

Description of the change:

Motivation for the change:

Checklist

  • Add or Modify a unit test for your change
  • Have you verified that tall the tests are passing?
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@wmedvede wmedvede changed the title SRVLOGIC-472: Job service job status change events are not sent in order [9.102.x-prod] SRVLOGIC-472: Job service job status change events are not sent in order Nov 26, 2024
@wmedvede wmedvede changed the title [9.102.x-prod] SRVLOGIC-472: Job service job status change events are not sent in order [DON'T MERGE] [9.102.x-prod] SRVLOGIC-472: Job service job status change events are not sent in order Nov 26, 2024
@wmedvede wmedvede force-pushed the SRVLOGIC-472-9.102.x-prod branch from 9147b9e to 0a60a22 Compare November 26, 2024 21:38
@wmedvede wmedvede requested a review from rgdoliveira November 26, 2024 21:39
@@ -919,7 +919,6 @@ func TestSonataFlowPlatformController(t *testing.T) {
validateTrigger(t, cl, "data-index-process-definition-", ksp.Namespace, ksp, trigger)
validateTrigger(t, cl, "data-index-process-error-", ksp.Namespace, ksp, trigger)
validateTrigger(t, cl, "data-index-process-node-", ksp.Namespace, ksp, trigger)
validateTrigger(t, cl, "data-index-process-sla-", ksp.Namespace, ksp, trigger)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ricardozanini Btw, the "data-index-process-sla-" was basically removed because the workflows don't produce this event, so we have basically one lees k8s object to create/maintain, etc.

@domhanak domhanak requested a review from jakubschwan November 27, 2024 07:45
@wmedvede wmedvede force-pushed the SRVLOGIC-472-9.102.x-prod branch from 0a60a22 to 922d339 Compare November 27, 2024 08:21
@wmedvede wmedvede changed the title [DON'T MERGE] [9.102.x-prod] SRVLOGIC-472: Job service job status change events are not sent in order [9.102.x-prod] SRVLOGIC-472: Job service job status change events are not sent in order Nov 27, 2024
@wmedvede wmedvede merged commit 3c81819 into kiegroup:9.102.x-prod Nov 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants