[incubator-kie-issues#814] Fix NPE on BaseKnowledgeBuilderResultImpl.…

…hashCode() (apache#3346) Co-authored-by: BAMOE CI <[email protected]>
kiegroup · Jan 17, 2024 · 2b4563c · 2b4563c
1 parent 5269d13
commit 2b4563c
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 21 deletions.
diff --git a/jbpm/jbpm-flow-builder/src/main/java/org/jbpm/assembler/DuplicateProcess.java b/jbpm/jbpm-flow-builder/src/main/java/org/jbpm/assembler/DuplicateProcess.java
@@ -28,16 +28,8 @@ public class DuplicateProcess extends ConfigurableSeverityResult {
     public static final String KEY = "duplicateProcess";
     private static final int[] line = new int[0];
 
-    private String processId;
-
     public DuplicateProcess(Process process, KnowledgeBuilderConfiguration config) {
-        super(process.getResource(), config);
-        processId = process.getId();
-    }
-
-    @Override
-    public String getMessage() {
-        return "Process with same id already exists: " + processId;
+        super(process.getResource(), config, "Process with same id already exists: " + process.getId());
     }
 
     @Override

diff --git a/jbpm/jbpm-flow-builder/src/main/java/org/jbpm/compiler/ProcessLoadError.java b/jbpm/jbpm-flow-builder/src/main/java/org/jbpm/compiler/ProcessLoadError.java
@@ -25,22 +25,18 @@
  * This is used for reporting errors with loading a ruleflow.
  */
 public class ProcessLoadError extends DroolsError {
-
-    private String message;
-    private Exception exception;
     private static final int[] lines = new int[0];
 
     public ProcessLoadError(Resource resource, String message, Exception nested) {
-        super(resource);
-        this.message = message;
-        this.exception = nested;
+        super(resource, getSpecificMessage(message, nested));
     }
 
+    @Override
     public int[] getLines() {
         return this.lines;
     }
 
-    public String getMessage() {
+    private static String getSpecificMessage(String message, Exception exception) {
         if (exception != null) {
             return message + " : Exception " + exception.getClass() + " : " + exception.getMessage();
         } else {

diff --git a/...dules/kogito-codegen-rules/src/main/java/org/kie/kogito/codegen/rules/QueryGenerator.java b/...dules/kogito-codegen-rules/src/main/java/org/kie/kogito/codegen/rules/QueryGenerator.java
@@ -212,14 +212,10 @@ public static class NoBindingQuery extends DroolsError {
         private final QueryModel query;
 
         public NoBindingQuery(QueryModel query) {
+            super("Query " + query.getName() + " has no bound variable. At least one binding is required to determine the value returned by this query");
             this.query = query;
         }
 
-        @Override
-        public String getMessage() {
-            return "Query " + query.getName() + " has no bound variable. At least one binding is required to determine the value returned by this query";
-        }
-
         @Override
         public int[] getLines() {
             return ERROR_LINES;