Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.101.x-prod] Add missing test annotation for prod build serverless workflow images #59

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

jakubschwan
Copy link

Many thanks for submitting your Pull Request ❤️!

Please make sure your PR meets the following requirements:

  • You have read the contributors guide
  • Pull Request title is properly formatted: [Issue XXXX] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Your feature/bug fix has a testcase that verifies it
  • You've tested the new feature/bug fix in an actual OpenShift cluster
  • You've added a RELEASE_NOTES.md entry regarding this change
How to retest this PR or trigger a specific build:
  • (Re)run Jenkins tests
    Please add comment: Jenkins [test|retest] this
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@jakubschwan
Copy link
Author

@rgdoliveira can you please provide review?

@rgdoliveira
Copy link
Member

@jakubschwan you opened it against main branch, can you please edit your PR and change the target branch to 9.101.x-prod?

@rgdoliveira rgdoliveira self-requested a review September 13, 2024 14:39
Copy link

@domhanak domhanak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we use some sort of patching or splitting of IT tests for the future.
This is pita to do each release.

@jakubschwan jakubschwan changed the base branch from main to 9.101.x-prod September 16, 2024 07:26
@jakubschwan
Copy link
Author

@jakubschwan you opened it against main branch, can you please edit your PR and change the target branch to 9.101.x-prod?

Oh, rookie mistake :( . Updated target branch to 9.101.x-prod. Thanks Roberto

@rgdoliveira rgdoliveira merged commit b49c61b into kiegroup:9.101.x-prod Sep 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants