Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.99.x-prod][SRVLOGIC-235] move maven plugins to plugin management and use go-offline option to make sure all deps are downloaded #15

Merged

Conversation

rgdoliveira
Copy link
Member

@rgdoliveira rgdoliveira commented Feb 27, 2024

PR for midstream main will follow soon.

Please make sure your PR meets the following requirements:

  • You have read the contributors guide
  • Pull Request title is properly formatted: [KOGITO|RHPAM-XYZ] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Your feature/bug fix has a testcase that verifies it
  • You've tested the new feature/bug fix in an actual OpenShift cluster
  • You've added a RELEASE_NOTES.md entry regarding this change
How to retest this PR or trigger a specific build:
  • (Re)run Jenkins tests
    Please add comment: Jenkins [test|retest] this
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

…line option to make sure all deps are downloaded
Copy link
Member

@wmedvede wmedvede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I don't want to introduce noice, so the maven-site plugin still remains in the productized/logic/pom.xml ?

@ricardozanini
Copy link
Member

ricardozanini commented Feb 27, 2024

@wmedvede it needs to be there since Quarkus needs it. Quarkus team is also taking a look at the issue to investigate why it's not been downloaded by their go-offline option. We also need to take a look at our upstream devmode image and see if the site plugin is on m2 folder. Or if it's been downloaded since we are not using "-o" option when starting the app.

Being on plugins management side shouldn't be a problem.

@rgdoliveira we might have to add this to upstream too. I'll take a look today.

Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rgdoliveira I'm missing the guava Red Hat library here. Can you confirm if this change also brings the jar file correctly?

@rgdoliveira
Copy link
Member Author

rgdoliveira commented Feb 27, 2024

@rgdoliveira I'm missing the guava Red Hat library here. Can you confirm if this change also brings the jar file correctly?

It got automatically added because of the usage of the go-offline.

In the maven repo there is now:

com/google/guava/listenablefuture/9999.0.0.empty-to-avoid-conflict-with-guava-redhat-00001
├── listenablefuture-9999.0.0.empty-to-avoid-conflict-with-guava-redhat-00001.jar
├── listenablefuture-9999.0.0.empty-to-avoid-conflict-with-guava-redhat-00001.jar.sha1
├── listenablefuture-9999.0.0.empty-to-avoid-conflict-with-guava-redhat-00001.pom
└── listenablefuture-9999.0.0.empty-to-avoid-conflict-with-guava-redhat-00001.pom.sha1

@rgdoliveira rgdoliveira merged commit 23e0f17 into kiegroup:9.99.x-prod Feb 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants