JBPM-9884 Dont allow to modify process variable of type Integer/Boole…

…an/..etc with invalid values through business-central console.
kiegroup · Sep 8, 2021 · ceb2789 · ceb2789
1 parent ff1a56c
commit ceb2789
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 5 deletions.
diff --git a/jbpm-flow/src/main/java/org/jbpm/process/core/datatype/impl/type/BooleanDataType.java b/jbpm-flow/src/main/java/org/jbpm/process/core/datatype/impl/type/BooleanDataType.java
@@ -41,7 +41,9 @@ public void writeExternal(ObjectOutput out) throws IOException {
 
  @Override
  public boolean verifyDataType(final Object value) {
- if ( value instanceof Boolean ) {
+ if (value == null) {
+ return true;
+ } else if (value instanceof Boolean || "true".equalsIgnoreCase(value.toString()) || "false".equalsIgnoreCase(value.toString())) {
  return true;
  }
  return false;

diff --git a/jbpm-flow/src/main/java/org/jbpm/process/core/datatype/impl/type/FloatDataType.java b/jbpm-flow/src/main/java/org/jbpm/process/core/datatype/impl/type/FloatDataType.java
@@ -20,6 +20,7 @@
 import java.io.ObjectInput;
 import java.io.ObjectOutput;
 
+import org.apache.commons.lang3.StringUtils;
 import org.jbpm.process.core.datatype.DataType;
 
 /**
@@ -41,9 +42,9 @@ public void writeExternal(ObjectOutput out) throws IOException {
 
  @Override
  public boolean verifyDataType(final Object value) {
- if ( value instanceof Float ) {
+ if (value == null) {
  return true;
- } else if ( value == null ) {
+ } else if (value instanceof Float || StringUtils.isNumeric(value.toString())) {
  return true;
  } else {
  return false;

diff --git a/jbpm-flow/src/main/java/org/jbpm/process/core/datatype/impl/type/IntegerDataType.java b/jbpm-flow/src/main/java/org/jbpm/process/core/datatype/impl/type/IntegerDataType.java
@@ -21,6 +21,7 @@
 import java.io.ObjectOutput;
 
 import org.jbpm.process.core.datatype.DataType;
+import org.apache.commons.lang3.StringUtils;
 
 /**
  * Representation of an integer datatype.
@@ -41,9 +42,9 @@ public void writeExternal(ObjectOutput out) throws IOException {
 
  @Override
  public boolean verifyDataType(final Object value) {
- if ( value instanceof Integer ) {
+ if (value == null) {
  return true;
- } else if ( value == null ) {
+ } else if (value instanceof Integer || StringUtils.isNumeric(value.toString())) {
  return true;
  } else {
  return false;
@@ -75,4 +76,8 @@ public Object valueOf(String value) {
  }
  }
 
+ public static void main(String[] args){
+ IntegerDataType idt = new IntegerDataType();
+ idt.verifyDataType("1234567");
+ }
 }