JBPM-9884 Dont allow to modify process variable of type Integer/Boole…

…an/..etc with invalid values through business-central console.
kiegroup · Dec 14, 2021 · 6afc6fc · 6afc6fc
1 parent aa0ded6
commit 6afc6fc
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 10 deletions.
diff --git a/jbpm-flow/src/main/java/org/jbpm/process/core/datatype/impl/type/BooleanDataType.java b/jbpm-flow/src/main/java/org/jbpm/process/core/datatype/impl/type/BooleanDataType.java
@@ -41,7 +41,9 @@ public void writeExternal(ObjectOutput out) throws IOException {
 
  @Override
  public boolean verifyDataType(final Object value) {
- if ( value instanceof Boolean ) {
+ if (value == null) {
+ return true;
+ } else if (value instanceof Boolean || "true".equalsIgnoreCase(value.toString()) || "false".equalsIgnoreCase(value.toString())) {
  return true;
  }
  return false;

diff --git a/jbpm-flow/src/main/java/org/jbpm/process/core/datatype/impl/type/FloatDataType.java b/jbpm-flow/src/main/java/org/jbpm/process/core/datatype/impl/type/FloatDataType.java
@@ -20,6 +20,7 @@
 import java.io.ObjectInput;
 import java.io.ObjectOutput;
 
+import org.apache.commons.lang3.StringUtils;
 import org.jbpm.process.core.datatype.DataType;
 
 /**
@@ -41,12 +42,15 @@ public void writeExternal(ObjectOutput out) throws IOException {
 
  @Override
  public boolean verifyDataType(final Object value) {
- if ( value instanceof Float ) {
- return true;
- } else if ( value == null ) {
+ if (value == null) {
  return true;
  } else {
- return false;
+ try {
+ Float.parseFloat(value.toString());
+ return true;
+ } catch (NumberFormatException e) {
+ return false;
+ }
  }
  }
 

diff --git a/jbpm-flow/src/main/java/org/jbpm/process/core/datatype/impl/type/IntegerDataType.java b/jbpm-flow/src/main/java/org/jbpm/process/core/datatype/impl/type/IntegerDataType.java
@@ -41,12 +41,15 @@ public void writeExternal(ObjectOutput out) throws IOException {
 
  @Override
  public boolean verifyDataType(final Object value) {
- if ( value instanceof Integer ) {
- return true;
- } else if ( value == null ) {
+ if (value == null) {
  return true;
  } else {
- return false;
+ try {
+ Integer.parseInt(value.toString());
+ return true;
+ } catch (NumberFormatException e) {
+ return false;
+ }
  }
  }
 
@@ -74,5 +77,4 @@ public Object valueOf(String value) {
  return value;
  }
  }
-
 }