Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHDM-2016] [KIE-766] EXISTS and NOT don't work correctly with multiple constrain… #3

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

tkobayas
Copy link

@tkobayas tkobayas commented Jan 12, 2024

…ts with BigDecimal (apache#5623)

Ports
This is a backport PR of apache#5623 for 7.x
for 7.67.x -> #8
for 7.67.x-blue -> #7

JIRA:
https://issues.redhat.com/browse/RHDM-2016

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • for pull request checks
    Please add comment: Jenkins retest this

  • for a specific pull request check
    Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] tests

  • for a full downstream build

    • for jenkins job: please add comment: Jenkins run fdb
    • for github actions job: add the label run_fdb
  • a compile downstream build please add comment: Jenkins run cdb

  • an upstream build please add comment: Jenkins run upstream

  • for quarkus branch checks
    Run checks against Quarkus current used branch
    Please add comment: Jenkins run quarkus-branch

  • for a quarkus branch specific check
    Run checks against Quarkus current used branch
    Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-branch

  • for quarkus main checks
    Run checks against Quarkus main branch
    Please add comment: Jenkins run quarkus-main

  • for a specific quarkus main check
    Run checks against Quarkus main branch
    Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-main

  • for quarkus lts checks
    Run checks against Quarkus lts branch
    Please add comment: Jenkins run quarkus-lts

  • for a specific quarkus lts check
    Run checks against Quarkus lts branch
    Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-lts

  • for native checks
    Run native checks
    Please add comment: Jenkins run native

  • for a specific native check
    Run native checks
    Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] native

  • for native lts checks
    Run native checks against quarkus lts branch
    Please add comment: Jenkins run native-lts

  • for a specific native lts check
    Run native checks against quarkus lts branch
    Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] native-lts

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@tkobayas
Copy link
Author

Jenkins retest this

@tkobayas
Copy link
Author

@mariofusco Please review and merge if it's okay this backport PR, thanks!

@mareknovotny
Copy link
Member

ok to test

@mareknovotny
Copy link
Member

jenkins do fdb

@tkobayas
Copy link
Author

FDB : Not related to this PR. Need a fix with another PR. It picks kie-jpmml-integration main instead of 7.x

[2024-01-12T13:38:45.227Z] [INFO] [kiegroup/kie-jpmml-integration]
[2024-01-12T13:38:45.227Z] [INFO]        Project taken from kiegroup/kie-jpmml-integration:main (Branch HEAD aa87638c67ca4e8dc301de0275e07efd9b6bdf30)
...
[2024-01-12T15:09:53.156Z] [INFO] --- maven-enforcer-plugin:3.0.0-M2:enforce (enforce-versions) @ kie-jpmml-integration ---
[2024-01-12T15:09:53.411Z] [WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireMavenVersion failed with message:
[2024-01-12T15:09:53.411Z] Detected Maven Version: 3.8.1 is not in the allowed range 3.8.6.
[2024-01-12T15:09:53.411Z] [INFO] ------------------------------------------------------------------------
[2024-01-12T15:09:53.411Z] [INFO] Reactor Summary for kie-jpmml-integration 8.45.0-SNAPSHOT:
[2024-01-12T15:09:53.411Z] [INFO]
[2024-01-12T15:09:53.411Z] [INFO] kie-jpmml-integration .............................. FAILURE [  0.786 s]

@mariofusco mariofusco merged commit b77e729 into kiegroup:7.x Jan 15, 2024
6 of 7 checks passed
@tkobayas tkobayas added backport-7.67.x Generate backport PR for 7.67.x branch backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch labels Jan 18, 2024
github-actions bot pushed a commit that referenced this pull request Jan 18, 2024
github-actions bot pushed a commit that referenced this pull request Jan 18, 2024
mariofusco pushed a commit that referenced this pull request Jan 22, 2024
mariofusco pushed a commit that referenced this pull request Jan 22, 2024
fantonangeli pushed a commit to fantonangeli/incubator-kie-drools that referenced this pull request Jan 26, 2024
Add configuration parameter to disable nexus deploy
rgdoliveira pushed a commit that referenced this pull request Nov 18, 2024
… (apache#6147)

* More unit tests migrated

* Migrate more tests to junit5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7.67.x Generate backport PR for 7.67.x branch backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants