Sync main branch with main-apache branch #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…che#5530) * Align with Apache parent bom. * Fix JavaDoc generation to original state. * Add changes requested in PR review.
* Fix javadoc, sources and distribution generation. * Remove duplicate javadoc plugin declaration. * Fix alphanetworkcompiler Java module name.
… Drools (apache#5548) * [DROOLS-7555] move automatic rest endpoints generation from Kogito to Drools * wip
* updateObjectTypesList() improvements * use isEmpty with findAny
apache#5553) * Update repositories and other small changes to Apache * Add missing mailing list configuration.
…e drools-drl parent module (apache#5564)
…utput in drools-traits (apache#5565)
…itive type (apache#5567) * Tests * All tests passing * Add integration tests. * Revert "Add integration tests." This reverts commit 98b9637. --------- Co-authored-by: Tibor Zimányi <[email protected]> Co-authored-by: Mario Fusco <[email protected]>
…odule (apache#5569) * Fixed order of imports * Fixed more checkstyle issues
…he#5576) * [DROOLS-7584] process completely all facts inserted before halt * fix imports order * fix testModifyWithFromSudoku to meet halt() (#22) --------- Co-authored-by: Toshiya Kobayashi <[email protected]>
…er module (apache#5574) * Fixed imports * Replaced tabs with spaces * Fixed issues with missing braces * fixed last class * Reverted changes for generated files. * Ignored warnings from generated files
… to a named entry-point (apache#5578)
* [KIE-686] fix peer update propagation for FromNode * Update drools-test-coverage/test-compiler-integration/src/test/java/org/drools/compiler/integrationtests/UnexpectedLoopTest.java Co-authored-by: Toshiya Kobayashi <[email protected]> --------- Co-authored-by: Toshiya Kobayashi <[email protected]>
* Added better gradle compatibility to AppPaths * Updated headers to Apache * Updated findBuildTool method to better identify gradle * Reverted findBuildTool changes
…sion .drl.yaml to be a native drools resource type (apache#5592) * [KIE-724] allow to write rules in yaml format making files with extension .drl.yaml to be a native drools resource type * add missing header
- additional fix in maven-compiler-plugin
Co-authored-by: jstastny-cz <[email protected]>
…pache#5594) - Introduced DeleteSpecificFactAction for retract_fact - Add a test case
apache#5618) * [KIE-748] drools executable-model fails with BigDecimal coercion for method arguments * refactor
…pache#5620) * Use UTF-8 when handling files and file content. * Fix memory compiler to use UTF-8 * Fix QueryGenerator to use UTF-8. * Revert selected fixes.
rgdoliveira
requested review from
mareknovotny,
ricardozanini and
fantonangeli
ricardozanini
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
LGTM
@mariofusco @lucamolteni this is our tentative to keep a production branch aligned with upstream (ASF). We have brought everything but the ci changes since we will have our own process.
|
@rgdoliveira maybe we should take a look at the failed CI? |
|
@ricardozanini I can be wrong, but the jobs that failed are using build-chain and it is probably trying to use branch So IMHO, we can ignore those failures until this repository become the official one and the current one is renamed and archived. |
This was referenced Dec 13, 2023
rgdoliveira
pushed a commit
that referenced
this pull request
Oct 25, 2024
…it5 - #1 (apache#6137) * Initial test migration * Migrated more unit tests * Migrated more unit tests * Fixed test * More tests migrated to junit5 * Fixed test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Thank you for submitting this pull request
NOTE!: Double check the target branch for this PR.
The default is
mainso it will target Drools 8 / Kogito.If this PR is not strictly related to drools and kogito project in
drools.git, it should probably target7.xas a branchPorts If a forward-port or a backport is needed, paste the forward port PR here
link
JIRA: (please edit the JIRA link if it exists)
link
referenced Pull Requests: (please edit the URLs of referenced pullrequests if they exist)
How to replicate CI configuration locally?
Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.
How to retest this PR or trigger a specific build:
for pull request checks
Please add comment: Jenkins retest this
for a specific pull request check
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] tests
for a full downstream build
run_fdba compile downstream build please add comment: Jenkins run cdb
an upstream build please add comment: Jenkins run upstream
for quarkus branch checks
Run checks against Quarkus current used branch
Please add comment: Jenkins run quarkus-branch
for a quarkus branch specific check
Run checks against Quarkus current used branch
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-branch
for quarkus main checks
Run checks against Quarkus main branch
Please add comment: Jenkins run quarkus-main
for a specific quarkus main check
Run checks against Quarkus main branch
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-main
for quarkus lts checks
Run checks against Quarkus lts branch
Please add comment: Jenkins run quarkus-lts
for a specific quarkus lts check
Run checks against Quarkus lts branch
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-lts
for native checks
Run native checks
Please add comment: Jenkins run native
for a specific native check
Run native checks
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] native
for native lts checks
Run native checks against quarkus lts branch
Please add comment: Jenkins run native-lts
for a specific native lts check
Run native checks against quarkus lts branch
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] native-lts
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>, where<branch-name>is the name of the branch where the pull request must be backported to (e.g.,backport-7.67.xto backport the original PR to the7.67.xbranch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.