-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DROOLS-7635] ansible-rulebook : Raise an error when a condition compares incompatible types #114
[DROOLS-7635] ansible-rulebook : Raise an error when a condition compares incompatible types #114
Conversation
…ares incompatible types - WIP: This doesn't support alpha index. Some tests fail
- support node sharing (but not merging error messages) - WIP: need more assertions
@mariofusco Limitation: in case of node sharing, the error message has only one ruleSetName/ruleName/conditionExpression. It means that when a user fixes a condition based on the error message, they may hit the similar issue in another condition next time. It might be invasive to "combine" error messages upon node sharing in drools code base. We may ask Madhu if it's important. Feel free to share your thought, thanks! |
The point I mentioned at #112 (comment) still remains
I'll need to consider further. |
...in/java/org/drools/ansible/rulebook/integration/api/domain/constraints/RulebookOperator.java
Outdated
Show resolved
Hide resolved
DO-NOT-MERGE until apache/incubator-kie-drools#6104 will be merged and the commit is synced to |
@tkobayas FYI I'm doing the sync in PR kiegroup/drools#80 |
…patible-type-02 [DROOLS-7635] ansible-rulebook : Raise an error when a condition compares incompatible types
…on compares incompatible types (#120) * Merge pull request #114 from tkobayas/DROOLS-7635-error-incompatible-type-02 [DROOLS-7635] ansible-rulebook : Raise an error when a condition compares incompatible types * [DROOLS-7635] ansible-rulebook : Raise an error when a condition comp… (#117) * [DROOLS-7635] ansible-rulebook : Raise an error when a condition compares incompatible types - alpha index test, beta index test beta index test fix add negate test and any test * refactor * minor comment fix
This draft PR requires
apache/incubator-kie-drools#6104
to be built beforhand.
Cross repo PR check doesn't work for now.