Skip to content

Commit

Permalink
[Console] Disable the monaco migration for 8.15 release (elastic#187237)
Browse files Browse the repository at this point in the history
## Summary

This PR disables the Monaco Console in 8.15 as we don't want to add it
to public release yet (it's planned to be released in 8.16).

**How to test:**
1. Check out the PR and start Es and Kibana
2. Verify that Console still uses the old Ace editor.

Co-authored-by: Elena Stoeva <[email protected]>
  • Loading branch information
yuliacech and ElenaStoeva authored Jul 8, 2024
1 parent c47cca3 commit b10c5bc
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/plugins/console/server/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ const schemaLatest = schema.object(
defaultValue: 'stack',
}),
}),
dev: schema.object({ enableMonaco: schema.boolean({ defaultValue: true }) }),
dev: schema.object({ enableMonaco: schema.boolean({ defaultValue: false }) }),
},
{ defaultValue: undefined }
);
Expand Down
8 changes: 8 additions & 0 deletions test/functional/apps/console/monaco/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,13 @@ export default async function ({ readConfigFile }: FtrConfigProviderContext) {
return configureHTTP2({
...functionalConfig.getAll(),
testFiles: [require.resolve('.')],
kbnTestServer: {
...functionalConfig.get('kbnTestServer'),
serverArgs: [
...functionalConfig.get('kbnTestServer.serverArgs'),
// enabling the monaco editor to run tests for it
`--console.dev.enableMonaco=true`,
],
},
});
}
2 changes: 1 addition & 1 deletion test/functional/config.ccs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export default async function ({ readConfigFile }: FtrConfigProviderContext) {
testFiles: [
require.resolve('./apps/dashboard/group3'),
require.resolve('./apps/discover/ccs_compatibility'),
require.resolve('./apps/console/monaco/_console_ccs'),
require.resolve('./apps/console/ace/_console_ccs'),
require.resolve('./apps/management/ccs_compatibility'),
require.resolve('./apps/getting_started'),
],
Expand Down
2 changes: 1 addition & 1 deletion test/functional/firefox/console.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export default async function ({ readConfigFile }: FtrConfigProviderContext) {
return {
...baseConfig.getAll(),

testFiles: [require.resolve('../apps/console/monaco')],
testFiles: [require.resolve('../apps/console/ace')],

junit: {
reportName: 'Firefox UI Functional Tests - Console',
Expand Down

0 comments on commit b10c5bc

Please sign in to comment.