Skip to content

Commit

Permalink
[Security Solution][Notes] - fix the notes link that is shown twice i…
Browse files Browse the repository at this point in the history
…n the search bar (elastic#198200)

## Summary

This PR fixes a minor inconvenience where the Kibana search bar was
showing 2 entries for the new Notes management page.

| Before fix | After fix |
| ------------- | ------------- |
| ![Screenshot 2024-10-29 at 11 53
44 AM](https://github.com/user-attachments/assets/77bd4b5a-d8d4-4f4f-8378-6aff1ec1b00b)
| ![Screenshot 2024-10-29 at 11 53
19 AM](https://github.com/user-attachments/assets/d138e307-b4ea-473b-9102-eb7e7b540bff)
|

Notes: this fix does not fix an issue happening in the space-specific
search, where Notes, Timelines and maybe other entries are appearing
twice. That issue seems to be related to the way we are removing then
adding back links to work with the new navigation. I looked into it but
could not find a way to fix yet, so this will be part of a follow up PR

elastic#197694
(cherry picked from commit ac5c74a)
  • Loading branch information
PhilippeOberti committed Oct 30, 2024
1 parent dcf5007 commit ae28d61
Showing 1 changed file with 1 addition and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,7 @@ export const links: LinkItem = {
skipUrlState: true,
hideTimeline: true,
hideWhenExperimentalKey: 'securitySolutionNotesDisabled',
globalSearchDisabled: true,
},
],
};
Expand Down

0 comments on commit ae28d61

Please sign in to comment.