Skip to content

Commit

Permalink
[8.x] [RCA] Fix extra margin on navigation menu (elastic#194142) (ela…
Browse files Browse the repository at this point in the history
…stic#194170)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[RCA] Fix extra margin on navigation menu
(elastic#194142)](elastic#194142)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Bena
Kansara","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-26T14:57:02Z","message":"[RCA]
Fix extra margin on navigation menu (elastic#194142)\n\nResolves
https://github.com/elastic/kibana/issues/194146\r\n\r\nRemoves extra
margin on top of left navigation
menu\r\n\r\n\r\nhttps://github.com/user-attachments/assets/bdcbac02-dff6-4824-8f15-020eb45b3d1f","sha":"4323814d48546983f632a8f67b012d30ded737e8","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","ci:project-deploy-observability","Team:obs-ux-management","v8.16.0","backport:version"],"title":"[RCA]
Fix extra margin on navigation
menu","number":194142,"url":"https://github.com/elastic/kibana/pull/194142","mergeCommit":{"message":"[RCA]
Fix extra margin on navigation menu (elastic#194142)\n\nResolves
https://github.com/elastic/kibana/issues/194146\r\n\r\nRemoves extra
margin on top of left navigation
menu\r\n\r\n\r\nhttps://github.com/user-attachments/assets/bdcbac02-dff6-4824-8f15-020eb45b3d1f","sha":"4323814d48546983f632a8f67b012d30ded737e8"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194142","number":194142,"mergeCommit":{"message":"[RCA]
Fix extra margin on navigation menu (elastic#194142)\n\nResolves
https://github.com/elastic/kibana/issues/194146\r\n\r\nRemoves extra
margin on top of left navigation
menu\r\n\r\n\r\nhttps://github.com/user-attachments/assets/bdcbac02-dff6-4824-8f15-020eb45b3d1f","sha":"4323814d48546983f632a8f67b012d30ded737e8"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Bena Kansara <[email protected]>
  • Loading branch information
kibanamachine and benakansara authored Sep 26, 2024
1 parent 48bf493 commit 9c3af40
Showing 1 changed file with 0 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@
* 2.0; you may not use this file except in compliance with the Elastic License
* 2.0.
*/
import { css } from '@emotion/css';
import {
APP_WRAPPER_CLASS,
AppMountParameters,
AppStatus,
CoreSetup,
Expand Down Expand Up @@ -106,17 +104,8 @@ export class InvestigateAppPlugin
appMountParameters.element
);

const appWrapperClassName = css`
overflow: auto;
`;

const appWrapperElement = document.getElementsByClassName(APP_WRAPPER_CLASS)[1];

appWrapperElement.classList.add(appWrapperClassName);

return () => {
ReactDOM.unmountComponentAtNode(appMountParameters.element);
appWrapperElement.classList.remove(appWrapperClassName);
};
},
});
Expand Down

0 comments on commit 9c3af40

Please sign in to comment.