Skip to content

Commit

Permalink
[8.x] [Inventory] Remove `Actions` tooltip (elastic#201231) (
Browse files Browse the repository at this point in the history
…elastic#201368)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Inventory] Remove `Actions` tooltip
(elastic#201231)](elastic#201231)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Sergi
Romeu","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-22T12:29:37Z","message":"[Inventory]
Remove `Actions` tooltip (elastic#201231)\n\n## Summary\n\nCloses
https://github.com/elastic/kibana/issues/199500\n\nThis PR removes the
Actions tooltip in the Entities Table.\n\n## Screenshots\n| Before |
After
|\n\n|-------------------------------------------------------------------------------------------|-------------------------------------------------------------------------------------------|\n\n|![image](https://github.com/user-attachments/assets/c661245a-7d07-4203-b832-a59acc20259c)|<img\nwidth=\"1441\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/29884aa1-3d82-4e0e-ae88-222fc8edf438\">|\n\n##
How to test\n1. Go to Inventory\n2. Check the columns of the Entities
table, the tooltip + help button\nshould now be
gone.","sha":"62fad394e131e3629e1252cb6d28b9df8eff004b","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services"],"title":"[Inventory]
Remove `Actions`
tooltip","number":201231,"url":"https://github.com/elastic/kibana/pull/201231","mergeCommit":{"message":"[Inventory]
Remove `Actions` tooltip (elastic#201231)\n\n## Summary\n\nCloses
https://github.com/elastic/kibana/issues/199500\n\nThis PR removes the
Actions tooltip in the Entities Table.\n\n## Screenshots\n| Before |
After
|\n\n|-------------------------------------------------------------------------------------------|-------------------------------------------------------------------------------------------|\n\n|![image](https://github.com/user-attachments/assets/c661245a-7d07-4203-b832-a59acc20259c)|<img\nwidth=\"1441\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/29884aa1-3d82-4e0e-ae88-222fc8edf438\">|\n\n##
How to test\n1. Go to Inventory\n2. Check the columns of the Entities
table, the tooltip + help button\nshould now be
gone.","sha":"62fad394e131e3629e1252cb6d28b9df8eff004b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201231","number":201231,"mergeCommit":{"message":"[Inventory]
Remove `Actions` tooltip (elastic#201231)\n\n## Summary\n\nCloses
https://github.com/elastic/kibana/issues/199500\n\nThis PR removes the
Actions tooltip in the Entities Table.\n\n## Screenshots\n| Before |
After
|\n\n|-------------------------------------------------------------------------------------------|-------------------------------------------------------------------------------------------|\n\n|![image](https://github.com/user-attachments/assets/c661245a-7d07-4203-b832-a59acc20259c)|<img\nwidth=\"1441\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/29884aa1-3d82-4e0e-ae88-222fc8edf438\">|\n\n##
How to test\n1. Go to Inventory\n2. Check the columns of the Entities
table, the tooltip + help button\nshould now be
gone.","sha":"62fad394e131e3629e1252cb6d28b9df8eff004b"}}]}] BACKPORT-->

Co-authored-by: Sergi Romeu <[email protected]>
  • Loading branch information
kibanamachine and rmyz authored Nov 22, 2024
1 parent 0fcf660 commit 6b0466c
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,7 @@ export const getColumns = ({
id: 'actions' as const,
// keep it for accessibility purposes
displayAsText: entityActionsLabel,
display: (
<CustomHeaderCell title={entityActionsLabel} tooltipContent={entityActionsLabel} />
),
display: <span>{entityActionsLabel}</span>,
initialWidth: 100,
},
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ export function EntitiesGrid({
<EuiText size="s">
<FormattedMessage
id="xpack.inventory.entitiesGrid.euiDataGrid.headerLeft"
defaultMessage="Showing {currentItems} of {total} {boldEntites}"
defaultMessage="Showing {currentItems} of {total} {boldEntities}"
values={{
currentItems: (
<strong>
Expand All @@ -169,10 +169,10 @@ export function EntitiesGrid({
</strong>
),
total: entities.length,
boldEntites: (
boldEntities: (
<strong>
{i18n.translate(
'xpack.inventory.entitiesGrid.euiDataGrid.headerLeft.entites',
'xpack.inventory.entitiesGrid.euiDataGrid.headerLeft.entities',
{ defaultMessage: 'Entities' }
)}
</strong>
Expand Down
4 changes: 2 additions & 2 deletions x-pack/plugins/translations/translations/fr-FR.json
Original file line number Diff line number Diff line change
Expand Up @@ -26198,8 +26198,8 @@
"xpack.inventory.entitiesGrid.euiDataGrid.alertsTooltip": "Le nombre d'alertes actives",
"xpack.inventory.entitiesGrid.euiDataGrid.entityNameLabel": "Nom de l'entité",
"xpack.inventory.entitiesGrid.euiDataGrid.entityNameTooltip": "Nom de l'entité (entity.displayName)",
"xpack.inventory.entitiesGrid.euiDataGrid.headerLeft": "Affichage de {currentItems} sur {total} {boldEntites}",
"xpack.inventory.entitiesGrid.euiDataGrid.headerLeft.entites": "Entités",
"xpack.inventory.entitiesGrid.euiDataGrid.headerLeft": "Affichage de {currentItems} sur {total} {boldEntities}",
"xpack.inventory.entitiesGrid.euiDataGrid.headerLeft.entities": "Entités",
"xpack.inventory.entitiesGrid.euiDataGrid.inventoryEntitiesGridLabel": "Grille des entités d'inventaire",
"xpack.inventory.entitiesGrid.euiDataGrid.lastSeen": "{date} à {time}",
"xpack.inventory.entitiesGrid.euiDataGrid.lastSeenLabel": "Vu en dernier",
Expand Down
4 changes: 2 additions & 2 deletions x-pack/plugins/translations/translations/ja-JP.json
Original file line number Diff line number Diff line change
Expand Up @@ -26170,8 +26170,8 @@
"xpack.inventory.entitiesGrid.euiDataGrid.alertsTooltip": "アクティブなアラートの件数",
"xpack.inventory.entitiesGrid.euiDataGrid.entityNameLabel": "エンティティ名",
"xpack.inventory.entitiesGrid.euiDataGrid.entityNameTooltip": "エンティティの名前(entity.displayName)",
"xpack.inventory.entitiesGrid.euiDataGrid.headerLeft": "{currentItems}/{total}個の{boldEntites}を表示中",
"xpack.inventory.entitiesGrid.euiDataGrid.headerLeft.entites": "エンティティ",
"xpack.inventory.entitiesGrid.euiDataGrid.headerLeft": "{currentItems}/{total}個の{boldEntities}を表示中",
"xpack.inventory.entitiesGrid.euiDataGrid.headerLeft.entities": "エンティティ",
"xpack.inventory.entitiesGrid.euiDataGrid.inventoryEntitiesGridLabel": "インベントリエンティティグリッド",
"xpack.inventory.entitiesGrid.euiDataGrid.lastSeen": "{date} @ {time}",
"xpack.inventory.entitiesGrid.euiDataGrid.lastSeenLabel": "前回の認識",
Expand Down
4 changes: 2 additions & 2 deletions x-pack/plugins/translations/translations/zh-CN.json
Original file line number Diff line number Diff line change
Expand Up @@ -26226,8 +26226,8 @@
"xpack.inventory.entitiesGrid.euiDataGrid.alertsTooltip": "活动告警计数",
"xpack.inventory.entitiesGrid.euiDataGrid.entityNameLabel": "实体名称",
"xpack.inventory.entitiesGrid.euiDataGrid.entityNameTooltip": "实体的名称 (entity.displayName)",
"xpack.inventory.entitiesGrid.euiDataGrid.headerLeft": "正在显示 {currentItems} 个(共 {total} 个){boldEntites}",
"xpack.inventory.entitiesGrid.euiDataGrid.headerLeft.entites": "实体",
"xpack.inventory.entitiesGrid.euiDataGrid.headerLeft": "正在显示 {currentItems} 个(共 {total} 个){boldEntities}",
"xpack.inventory.entitiesGrid.euiDataGrid.headerLeft.entities": "实体",
"xpack.inventory.entitiesGrid.euiDataGrid.inventoryEntitiesGridLabel": "库存实体网格",
"xpack.inventory.entitiesGrid.euiDataGrid.lastSeen": "{date} @ {time}",
"xpack.inventory.entitiesGrid.euiDataGrid.lastSeenLabel": "最后看到时间",
Expand Down

0 comments on commit 6b0466c

Please sign in to comment.