Skip to content

Commit

Permalink
[8.x] [ML] Data Frame Analytics: removing scss overrides for explorat…
Browse files Browse the repository at this point in the history
…ion pages (elastic#197724) (elastic#198157)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ML] Data Frame Analytics: removing scss overrides for exploration
pages (elastic#197724)](elastic#197724)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Melissa
Alvarez","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-29T15:41:57Z","message":"[ML]
Data Frame Analytics: removing scss overrides for exploration pages
(elastic#197724)\n\n## Summary\r\n\r\nRelated meta issue:
https://github.com/elastic/kibana/issues/140695\r\n\r\nRegression model
evaluation before:\r\n\r\n<img width=\"1455\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/cfdb794d-4576-4c10-96c1-0b3856857cdd\">\r\n\r\nAfter:\r\n\r\n<img
width=\"1455\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/4c2bbdf3-85ef-489e-bc3a-1281d3531328\">\r\n\r\n\r\nClassification
evaluation before:\r\n\r\n<img width=\"1474\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/e565cac3-8c1d-4e4f-8cac-7ea8abf4358d\">\r\n\r\nAfter
switching fully to flex layout as we no longer support IE11 and\r\nall
the workarounds were no longer needed (Note it's all left
aligned\r\nnow):\r\n\r\n<img width=\"1467\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/280ea446-17fc-4622-a925-57ef6c01cd89\">\r\n\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [ ] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [ ] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n- [ ] Any UI touched in this PR is
usable by keyboard only (learn more\r\nabout [keyboard
accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI
touched in this PR does not create any new axe failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[ ] If a plugin configuration key changed, check if it needs to
be\r\nallowlisted in the cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[ ] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[ ] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"669dc381bfc671637d4763930c8b4ede7ad7fbf3","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","release_note:skip","Feature:Data
Frame Analytics","v9.0.0","backport:version","v8.17.0"],"title":"[ML]
Data Frame Analytics: removing scss overrides for exploration pages
","number":197724,"url":"https://github.com/elastic/kibana/pull/197724","mergeCommit":{"message":"[ML]
Data Frame Analytics: removing scss overrides for exploration pages
(elastic#197724)\n\n## Summary\r\n\r\nRelated meta issue:
https://github.com/elastic/kibana/issues/140695\r\n\r\nRegression model
evaluation before:\r\n\r\n<img width=\"1455\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/cfdb794d-4576-4c10-96c1-0b3856857cdd\">\r\n\r\nAfter:\r\n\r\n<img
width=\"1455\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/4c2bbdf3-85ef-489e-bc3a-1281d3531328\">\r\n\r\n\r\nClassification
evaluation before:\r\n\r\n<img width=\"1474\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/e565cac3-8c1d-4e4f-8cac-7ea8abf4358d\">\r\n\r\nAfter
switching fully to flex layout as we no longer support IE11 and\r\nall
the workarounds were no longer needed (Note it's all left
aligned\r\nnow):\r\n\r\n<img width=\"1467\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/280ea446-17fc-4622-a925-57ef6c01cd89\">\r\n\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [ ] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [ ] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n- [ ] Any UI touched in this PR is
usable by keyboard only (learn more\r\nabout [keyboard
accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI
touched in this PR does not create any new axe failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[ ] If a plugin configuration key changed, check if it needs to
be\r\nallowlisted in the cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[ ] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[ ] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"669dc381bfc671637d4763930c8b4ede7ad7fbf3"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197724","number":197724,"mergeCommit":{"message":"[ML]
Data Frame Analytics: removing scss overrides for exploration pages
(elastic#197724)\n\n## Summary\r\n\r\nRelated meta issue:
https://github.com/elastic/kibana/issues/140695\r\n\r\nRegression model
evaluation before:\r\n\r\n<img width=\"1455\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/cfdb794d-4576-4c10-96c1-0b3856857cdd\">\r\n\r\nAfter:\r\n\r\n<img
width=\"1455\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/4c2bbdf3-85ef-489e-bc3a-1281d3531328\">\r\n\r\n\r\nClassification
evaluation before:\r\n\r\n<img width=\"1474\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/e565cac3-8c1d-4e4f-8cac-7ea8abf4358d\">\r\n\r\nAfter
switching fully to flex layout as we no longer support IE11 and\r\nall
the workarounds were no longer needed (Note it's all left
aligned\r\nnow):\r\n\r\n<img width=\"1467\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/280ea446-17fc-4622-a925-57ef6c01cd89\">\r\n\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [ ] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [ ] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n- [ ] Any UI touched in this PR is
usable by keyboard only (learn more\r\nabout [keyboard
accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI
touched in this PR does not create any new axe failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[ ] If a plugin configuration key changed, check if it needs to
be\r\nallowlisted in the cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[ ] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[ ] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"669dc381bfc671637d4763930c8b4ede7ad7fbf3"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Melissa Alvarez <[email protected]>
  • Loading branch information
kibanamachine and alvarezmelissa87 authored Oct 30, 2024
1 parent 85090ca commit 68a7d5e
Show file tree
Hide file tree
Showing 17 changed files with 381 additions and 414 deletions.
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
@import 'pages/analytics_exploration/components/regression_exploration/index';
@import 'pages/job_map/components/index';
@import 'pages/analytics_management/components/analytics_list/index';
@import 'pages/analytics_management/components/create_analytics_button/index';
@import 'pages/analytics_creation/components/index';
@import 'pages/analytics_creation/components/index';

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -19,18 +19,16 @@ interface Props {
}

export const ClassificationExploration: FC<Props> = ({ jobId }) => (
<div className="mlDataFrameAnalyticsClassification">
<ExplorationPageWrapper
jobId={jobId}
title={i18n.translate(
'xpack.ml.dataframe.analytics.classificationExploration.tableJobIdTitle',
{
defaultMessage: 'Destination index for classification job ID {jobId}',
values: { jobId },
}
)}
EvaluatePanel={EvaluatePanel}
FeatureImportanceSummaryPanel={FeatureImportanceSummaryPanel}
/>
</div>
<ExplorationPageWrapper
jobId={jobId}
title={i18n.translate(
'xpack.ml.dataframe.analytics.classificationExploration.tableJobIdTitle',
{
defaultMessage: 'Destination index for classification job ID {jobId}',
values: { jobId },
}
)}
EvaluatePanel={EvaluatePanel}
FeatureImportanceSummaryPanel={FeatureImportanceSummaryPanel}
/>
);
Loading

0 comments on commit 68a7d5e

Please sign in to comment.