Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[8.x] Remove unused field (elastic#194084) (elastic#194417)
# Backport This will backport the following commits from `main` to `8.x`: - [Remove unused field (elastic#194084)](elastic#194084) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Toby Brain","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-26T11:05:44Z","message":"Remove unused field (elastic#194084)\n\n## Summary\n\nThe API\n[model](https://github.com/elastic/kibana/blob/main/x-pack/plugins/fleet/common/types/rest_spec/package_policy.ts#L48)\n(points\n[here](https://github.com/elastic/kibana/blob/main/x-pack/plugins/fleet/common/types/rest_spec/package_policy.ts#L40-L42))\ndoesn't actually define this field and it's not returned by the server.\n\nRelated to\nhttps://github.com/elastic/terraform-provider-elasticstack/pull/787#discussion_r1772562187\n\n\n### Checklist\n\nDelete any items that are not applicable to this PR.\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\n- [x]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\n- [x] Any UI touched in this PR does not create any new axe failures\n(run axe in browser:\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\n- [x] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [x] This renders correctly on smaller devices using a responsive\nlayout. (You can test this [in your\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\n- [x] This was checked for [cross-browser\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\n\n### For maintainers\n\n- [ ] This was checked for breaking API changes and was [labeled\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"be9dd06f7483a9972f60eea41fd4f00511c864fa","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["v9.0.0","backport:prev-minor"],"title":"Remove unused field","number":194084,"url":"https://github.com/elastic/kibana/pull/194084","mergeCommit":{"message":"Remove unused field (elastic#194084)\n\n## Summary\n\nThe API\n[model](https://github.com/elastic/kibana/blob/main/x-pack/plugins/fleet/common/types/rest_spec/package_policy.ts#L48)\n(points\n[here](https://github.com/elastic/kibana/blob/main/x-pack/plugins/fleet/common/types/rest_spec/package_policy.ts#L40-L42))\ndoesn't actually define this field and it's not returned by the server.\n\nRelated to\nhttps://github.com/elastic/terraform-provider-elasticstack/pull/787#discussion_r1772562187\n\n\n### Checklist\n\nDelete any items that are not applicable to this PR.\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\n- [x]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\n- [x] Any UI touched in this PR does not create any new axe failures\n(run axe in browser:\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\n- [x] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [x] This renders correctly on smaller devices using a responsive\nlayout. (You can test this [in your\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\n- [x] This was checked for [cross-browser\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\n\n### For maintainers\n\n- [ ] This was checked for breaking API changes and was [labeled\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"be9dd06f7483a9972f60eea41fd4f00511c864fa"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194084","number":194084,"mergeCommit":{"message":"Remove unused field (elastic#194084)\n\n## Summary\n\nThe API\n[model](https://github.com/elastic/kibana/blob/main/x-pack/plugins/fleet/common/types/rest_spec/package_policy.ts#L48)\n(points\n[here](https://github.com/elastic/kibana/blob/main/x-pack/plugins/fleet/common/types/rest_spec/package_policy.ts#L40-L42))\ndoesn't actually define this field and it's not returned by the server.\n\nRelated to\nhttps://github.com/elastic/terraform-provider-elasticstack/pull/787#discussion_r1772562187\n\n\n### Checklist\n\nDelete any items that are not applicable to this PR.\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\n- [x]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\n- [x] Any UI touched in this PR does not create any new axe failures\n(run axe in browser:\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\n- [x] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [x] This renders correctly on smaller devices using a responsive\nlayout. (You can test this [in your\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\n- [x] This was checked for [cross-browser\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\n\n### For maintainers\n\n- [ ] This was checked for breaking API changes and was [labeled\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"be9dd06f7483a9972f60eea41fd4f00511c864fa"}}]}] BACKPORT--> Co-authored-by: Toby Brain <[email protected]>
- Loading branch information
1 parent
4e13979
commit 5afb442