Skip to content

Commit

Permalink
[8.12] [ML] Remove beta badge from ML alerting rules (elastic#173545) (…
Browse files Browse the repository at this point in the history 
…elastic#173623)

# Backport

This will backport the following commits from `main` to `8.12`:
- [[ML] Remove beta badge from ML alerting rules
(elastic#173545)](elastic#173545)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dima
Arnautov","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-12-19T13:13:02Z","message":"[ML]
Remove beta badge from ML alerting rules (elastic#173545)\n\n##
Summary\r\n\r\n- Removes the beta badge from Anomaly detection and
Anomlay detection\r\njob health alerting rules.\r\n- Renames Anomaly
detection alerting rule (\"Anomaly detection alert\" ->\r\n\"Anomaly
detection\") for consistency with the other rules in the
list","sha":"bf52a1396dfe0724d826744ddfbf20b16bebe1bb","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement",":ml","Feature:Anomaly
Detection","Feature:Alerting/RuleTypes","Team:ML","v8.12.0","v8.13.0"],"number":173545,"url":"https://github.com/elastic/kibana/pull/173545","mergeCommit":{"message":"[ML]
Remove beta badge from ML alerting rules (elastic#173545)\n\n##
Summary\r\n\r\n- Removes the beta badge from Anomaly detection and
Anomlay detection\r\njob health alerting rules.\r\n- Renames Anomaly
detection alerting rule (\"Anomaly detection alert\" ->\r\n\"Anomaly
detection\") for consistency with the other rules in the
list","sha":"bf52a1396dfe0724d826744ddfbf20b16bebe1bb"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/173545","number":173545,"mergeCommit":{"message":"[ML]
Remove beta badge from ML alerting rules (elastic#173545)\n\n##
Summary\r\n\r\n- Removes the beta badge from Anomaly detection and
Anomlay detection\r\njob health alerting rules.\r\n- Renames Anomaly
detection alerting rule (\"Anomaly detection alert\" ->\r\n\"Anomaly
detection\") for consistency with the other rules in the
list","sha":"bf52a1396dfe0724d826744ddfbf20b16bebe1bb"}}]}] BACKPORT-->

Co-authored-by: Dima Arnautov <[email protected]>
  • Loading branch information
@kibanamachine @darnautov
kibanamachine and darnautov authored Dec 19, 2023
1 parent d36413a commit 49f8243
Show file tree
Hide file tree
Showing 7 changed files with 1 addition and 52 deletions.
25 changes: 0 additions & 25 deletions x-pack/plugins/ml/public/alerting/beta_badge.tsx
View file

This file was deleted.

10 changes: 0 additions & 10 deletions ...lugins/ml/public/alerting/jobs_health_rule/anomaly_detection_jobs_health_rule_trigger.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import { HttpService } from '../../application/services/http_service';
import { useMlKibana } from '../../application/contexts/kibana';
import { TestsSelectionControl } from './tests_selection_control';
import { ALL_JOBS_SELECTION } from '../../../common/constants/alerts';
import { BetaBadge } from '../beta_badge';

export type MlAnomalyAlertTriggerProps =
RuleTypeParamsExpressionProps<MlAnomalyDetectionJobsHealthRuleParams>;
Expand Down Expand Up @@ -108,15 +107,6 @@ const AnomalyDetectionJobsHealthRuleTrigger: FC<MlAnomalyAlertTriggerProps> = ({
error={formErrors}
isInvalid={isFormInvalid}
>
<BetaBadge
message={i18n.translate(
'xpack.ml.alertTypes.jobsHealthAlertingRule.betaBadgeTooltipContent',
{
defaultMessage: `Anomaly detection job health alerts are a beta feature. We'd love to hear your feedback.`,
}
)}
/>

<JobSelectorControl
jobsAndGroupIds={includeJobsAndGroupIds}
adJobsApiService={adJobsApiService}
Expand Down
7 changes: 0 additions & 7 deletions x-pack/plugins/ml/public/alerting/ml_anomaly_alert_trigger.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ import { CombinedJobWithStats } from '../../common/types/anomaly_detection_jobs'
import { AdvancedSettings } from './advanced_settings';
import { getLookbackInterval, getTopNBuckets } from '../../common/util/alerts';
import { parseInterval } from '../../common/util/parse_interval';
import { BetaBadge } from './beta_badge';

export type MlAnomalyAlertTriggerProps =
RuleTypeParamsExpressionProps<MlAnomalyDetectionAlertParams>;
Expand Down Expand Up @@ -158,12 +157,6 @@ const MlAnomalyAlertTrigger: FC<MlAnomalyAlertTriggerProps> = ({

return (
<EuiForm data-test-subj={'mlAnomalyAlertForm'}>
<BetaBadge
message={i18n.translate('xpack.ml.anomalyDetectionAlert.betaBadgeTooltipContent', {
defaultMessage: `Anomaly detection alerts are a beta feature. We'd love to hear your feedback.`,
})}
/>

<JobSelectorControl
jobsAndGroupIds={jobsAndGroupIds}
adJobsApiService={adJobsApiService}
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/ml/server/lib/alerts/register_anomaly_detection_alert_type.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ export function registerAnomalyDetectionAlertType({
>({
id: ML_ALERT_TYPES.ANOMALY_DETECTION,
name: i18n.translate('xpack.ml.anomalyDetectionAlert.name', {
defaultMessage: 'Anomaly detection alert',
defaultMessage: 'Anomaly detection',
}),
actionGroups: [THRESHOLD_MET_GROUP],
defaultActionGroupId: ANOMALY_SCORE_MATCH_GROUP_ID,
Expand Down
3 changes: 0 additions & 3 deletions x-pack/plugins/translations/translations/fr-FR.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24675,7 +24675,6 @@
"xpack.ml.alertTypes.jobsHealthAlertingRule.alertContext.resultsDescription": "Résultats de l'exécution de la règle",
"xpack.ml.alertTypes.jobsHealthAlertingRule.behindRealtimeCheckDescription": "La tâche est en retard sur le temps réel",
"xpack.ml.alertTypes.jobsHealthAlertingRule.behindRealtimeCheckName": "La tâche est en retard sur le temps réel",
"xpack.ml.alertTypes.jobsHealthAlertingRule.betaBadgeTooltipContent": "La fonctionnalité d'alerte d’intégrité des tâches de détection des anomalies est en version bêta. Nous aimerions beaucoup connaître votre avis.",
"xpack.ml.alertTypes.jobsHealthAlertingRule.datafeedCheckDescription": "Soyez alerté si le flux de données correspondant de la tâche n'est pas démarré",
"xpack.ml.alertTypes.jobsHealthAlertingRule.datafeedCheckName": "Le flux de données n'est pas démarré",
"xpack.ml.alertTypes.jobsHealthAlertingRule.defaultActionMessage": "[\\{\\{rule.name\\}\\}] Résultat du contrôle d'intégrité des tâches de détection des anomalies :\n\\{\\{context.message\\}\\}\n\\{\\{#context.results\\}\\}\n ID de tâche : \\{\\{job_id\\}\\}\n \\{\\{#datafeed_id\\}\\}ID de flux de données : \\{\\{datafeed_id\\}\\}\n \\{\\{/datafeed_id\\}\\}\\{\\{#datafeed_state\\}\\}État du flux de données : \\{\\{datafeed_state\\}\\}\n \\{\\{/datafeed_state\\}\\}\\{\\{#memory_status\\}\\}Statut de la mémoire : \\{\\{memory_status\\}\\}\n \\{\\{/memory_status\\}\\}\\{\\{#model_bytes\\}\\}Taille du modèle : \\{\\{model_bytes\\}\\}\n \\{\\{/model_bytes\\}\\}\\{\\{#model_bytes_memory_limit\\}\\}Limite de mémoire du modèle : \\{\\{model_bytes_memory_limit\\}\\}\n \\{\\{/model_bytes_memory_limit\\}\\}\\{\\{#peak_model_bytes\\}\\}Pic d'octets du modèle : \\{\\{peak_model_bytes\\}\\}\n \\{\\{/peak_model_bytes\\}\\}\\{\\{#model_bytes_exceeded\\}\\}Dépassement du modèle : \\{\\{model_bytes_exceeded\\}\\}\n \\{\\{/model_bytes_exceeded\\}\\}\\{\\{#log_time\\}\\}Heure de logging dans la mémoire : \\{\\{log_time\\}\\}\n \\{\\{/log_time\\}\\}\\{\\{#failed_category_count\\}\\}Compte de catégories échouées : \\{\\{failed_category_count\\}\\}\n \\{\\{/failed_category_count\\}\\}\\{\\{#annotation\\}\\}Annotation : \\{\\{annotation\\}\\}\n \\{\\{/annotation\\}\\}\\{\\{#missed_docs_count\\}\\}Nombre de documents manquants : \\{\\{missed_docs_count\\}\\}\n \\{\\{/missed_docs_count\\}\\}\\{\\{#end_timestamp\\}\\}Dernier groupe finalisé avec les documents manquants : \\{\\{end_timestamp\\}\\}\n \\{\\{/end_timestamp\\}\\}\\{\\{#errors\\}\\}Message d'erreur : \\{\\{message\\}\\} \\{\\{/errors\\}\\}\n\\{\\{/context.results\\}\\}\n",
Expand Down Expand Up @@ -24839,8 +24838,6 @@
"xpack.ml.anomalyDetection.singleMetricViewerLabel": "Single Metric Viewer (Visionneuse d'indicateur unique)",
"xpack.ml.anomalyDetectionAlert.actionGroupName": "Le score d'anomalies correspond à la condition",
"xpack.ml.anomalyDetectionAlert.advancedSettingsLabel": "Paramètres avancés",
"xpack.ml.anomalyDetectionAlert.betaBadgeLabel": "Bêta",
"xpack.ml.anomalyDetectionAlert.betaBadgeTooltipContent": "La fonctionnalité d'alerte de détection des anomalies est en version bêta. Nous aimerions beaucoup connaître votre avis.",
"xpack.ml.anomalyDetectionAlert.errorFetchingJobs": "Impossible de récupérer la configuration des tâches",
"xpack.ml.anomalyDetectionAlert.lookbackIntervalDescription": "Intervalle de temps pendant lequel les données d'anomalie sont interrogées lors de chaque vérification de condition de règle. Par défaut, il est dérivé de la durée d'intervalle de la tâche et du retard de requête du flux de données.",
"xpack.ml.anomalyDetectionAlert.lookbackIntervalLabel": "Intervalle d'historique",
Expand Down
3 changes: 0 additions & 3 deletions x-pack/plugins/translations/translations/ja-JP.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24675,7 +24675,6 @@
"xpack.ml.alertTypes.jobsHealthAlertingRule.alertContext.resultsDescription": "ルール実行の結果",
"xpack.ml.alertTypes.jobsHealthAlertingRule.behindRealtimeCheckDescription": "ジョブはリアルタイムより遅れて実行されています",
"xpack.ml.alertTypes.jobsHealthAlertingRule.behindRealtimeCheckName": "ジョブはリアルタイムより遅れて実行されています",
"xpack.ml.alertTypes.jobsHealthAlertingRule.betaBadgeTooltipContent": "異常検知ジョブ正常性アラートはベータ版の機能です。フィードバックをお待ちしています。",
"xpack.ml.alertTypes.jobsHealthAlertingRule.datafeedCheckDescription": "ジョブの対応するデータフィードが開始していない場合にアラートで通知します",
"xpack.ml.alertTypes.jobsHealthAlertingRule.datafeedCheckName": "データフィードが開始していません",
"xpack.ml.alertTypes.jobsHealthAlertingRule.defaultActionMessage": "[\\{\\{rule.name\\}\\}] 異常検知ジョブヘルスチェック結果：\n\\{\\{context.message\\}\\}\n\\{\\{#context.results\\}\\}\n ジョブID：\\{\\{job_id\\}\\}\n \\{\\{#datafeed_id\\}\\}データフィードID: \\{\\{datafeed_id\\}\\}\n \\{\\{/datafeed_id\\}\\}\\{\\{#datafeed_state\\}\\}データフィード状態：\\{\\{datafeed_state\\}\\}\n \\{\\{/datafeed_state\\}\\}\\{\\{#memory_status\\}\\}メモリステータス：\\{\\{memory_status\\}\\}\n \\{\\{/memory_status\\}\\}\\{\\{#model_bytes\\}\\}モデルサイズ：\\{\\{model_bytes\\}\\}\n \\{\\{/model_bytes\\}\\}\\{\\{#model_bytes_memory_limit\\}\\}モデルメモリ上限：\\{\\{model_bytes_memory_limit\\}\\}\n \\{\\{/model_bytes_memory_limit\\}\\}\\{\\{#peak_model_bytes\\}\\}ピークモデルバイト：\\{\\{peak_model_bytes\\}\\}\n \\{\\{/peak_model_bytes\\}\\}\\{\\{#model_bytes_exceeded\\}\\}モデルが超過しました：\\{\\{model_bytes_exceeded\\}\\}\n \\{\\{/model_bytes_exceeded\\}\\}\\{\\{#log_time\\}\\}メモリログ時間：\\{\\{log_time\\}\\}\n \\{\\{/log_time\\}\\}\\{\\{#failed_category_count\\}\\}失敗したカテゴリ件数：\\{\\{failed_category_count\\}\\}\n \\{\\{/failed_category_count\\}\\}\\{\\{#annotation\\}\\}注釈: \\{\\{annotation\\}\\}\n \\{\\{/annotation\\}\\}\\{\\{#missed_docs_count\\}\\}見つからないドキュメント数：\\{\\{missed_docs_count\\}\\}\n \\{\\{/missed_docs_count\\}\\}\\{\\{#end_timestamp\\}\\}見つからないドキュメントで最後に確定されたバケット：\\{\\{end_timestamp\\}\\}\n \\{\\{/end_timestamp\\}\\}\\{\\{#errors\\}\\}エラーメッセージ：\\{\\{message\\}\\} \\{\\{/errors\\}\\}\n\\{\\{/context.results\\}\\}\n",
Expand Down Expand Up @@ -24839,8 +24838,6 @@
"xpack.ml.anomalyDetection.singleMetricViewerLabel": "シングルメトリックビューアー",
"xpack.ml.anomalyDetectionAlert.actionGroupName": "異常スコアが条件と一致しました",
"xpack.ml.anomalyDetectionAlert.advancedSettingsLabel": "高度な設定",
"xpack.ml.anomalyDetectionAlert.betaBadgeLabel": "ベータ",
"xpack.ml.anomalyDetectionAlert.betaBadgeTooltipContent": "異常検知アラートはベータ版の機能です。フィードバックをお待ちしています。",
"xpack.ml.anomalyDetectionAlert.errorFetchingJobs": "ジョブ構成を取得できません",
"xpack.ml.anomalyDetectionAlert.lookbackIntervalDescription": "各ルール条件チェック中に異常データをクエリする時間間隔。デフォルトでは、ジョブのバケットスパンとデータフィードのクエリ遅延から取得されます。",
"xpack.ml.anomalyDetectionAlert.lookbackIntervalLabel": "ルックバック間隔",
Expand Down
3 changes: 0 additions & 3 deletions x-pack/plugins/translations/translations/zh-CN.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24673,7 +24673,6 @@
"xpack.ml.alertTypes.jobsHealthAlertingRule.alertContext.resultsDescription": "规则执行的结果",
"xpack.ml.alertTypes.jobsHealthAlertingRule.behindRealtimeCheckDescription": "作业的运行已落后",
"xpack.ml.alertTypes.jobsHealthAlertingRule.behindRealtimeCheckName": "作业的运行已落后",
"xpack.ml.alertTypes.jobsHealthAlertingRule.betaBadgeTooltipContent": "异常检测作业运行状况告警是公测版功能。我们很乐意听取您的反馈意见。",
"xpack.ml.alertTypes.jobsHealthAlertingRule.datafeedCheckDescription": "作业的对应数据馈送未启动时收到告警",
"xpack.ml.alertTypes.jobsHealthAlertingRule.datafeedCheckName": "数据馈送未启动",
"xpack.ml.alertTypes.jobsHealthAlertingRule.defaultActionMessage": "[\\{\\{rule.name\\}\\}] 异常检测作业运行状况检查结果：\n\\{\\{context.message\\}\\}\n\\{\\{#context.results\\}\\}\n 作业 ID：\\{\\{job_id\\}\\}\n \\{\\{#datafeed_id\\}\\}数据馈送 ID：\\{\\{datafeed_id\\}\\}\n \\{\\{/datafeed_id\\}\\}\\{\\{#datafeed_state\\}\\}数据馈送状态：\\{\\{datafeed_state\\}\\}\n \\{\\{/datafeed_state\\}\\}\\{\\{#memory_status\\}\\}内存状态：\\{\\{memory_status\\}\\}\n \\{\\{/memory_status\\}\\}\\{\\{#model_bytes\\}\\}模型大小：\\{\\{model_bytes\\}\\}\n \\{\\{/model_bytes\\}\\}\\{\\{#model_bytes_memory_limit\\}\\}模型内存限制：\\{\\{model_bytes_memory_limit\\}\\}\n \\{\\{/model_bytes_memory_limit\\}\\}\\{\\{#peak_model_bytes\\}\\}峰值模型字节数：\\{\\{peak_model_bytes\\}\\}\n \\{\\{/peak_model_bytes\\}\\}\\{\\{#model_bytes_exceeded\\}\\}模型已超出：\\{\\{model_bytes_exceeded\\}\\}\n \\{\\{/model_bytes_exceeded\\}\\}\\{\\{#log_time\\}\\}内存日志记录时间：\\{\\{log_time\\}\\}\n \\{\\{/log_time\\}\\}\\{\\{#failed_category_count\\}\\}失败类别计数：\\{\\{failed_category_count\\}\\}\n \\{\\{/failed_category_count\\}\\}\\{\\{#annotation\\}\\}标注：\\{\\{annotation\\}\\}\n \\{\\{/annotation\\}\\}\\{\\{#missed_docs_count\\}\\}缺失文档数：\\{\\{missed_docs_count\\}\\}\n \\{\\{/missed_docs_count\\}\\}\\{\\{#end_timestamp\\}\\}缺失文档的最新已完成存储桶：\\{\\{end_timestamp\\}\\}\n \\{\\{/end_timestamp\\}\\}\\{\\{#errors\\}\\}错误消息：\\{\\{message\\}\\} \\{\\{/errors\\}\\}\n\\{\\{/context.results\\}\\}\n",
Expand Down Expand Up @@ -24837,8 +24836,6 @@
"xpack.ml.anomalyDetection.singleMetricViewerLabel": "Single Metric Viewer",
"xpack.ml.anomalyDetectionAlert.actionGroupName": "异常分数匹配条件",
"xpack.ml.anomalyDetectionAlert.advancedSettingsLabel": "高级设置",
"xpack.ml.anomalyDetectionAlert.betaBadgeLabel": "公测版",
"xpack.ml.anomalyDetectionAlert.betaBadgeTooltipContent": "异常检测告警是公测版功能。我们很乐意听取您的反馈意见。",
"xpack.ml.anomalyDetectionAlert.errorFetchingJobs": "无法提取作业配置",
"xpack.ml.anomalyDetectionAlert.lookbackIntervalDescription": "每个规则条件检查期间用于查询异常数据的时间间隔。默认情况下，派生自作业的存储桶跨度和数据馈送的查询延迟。",
"xpack.ml.anomalyDetectionAlert.lookbackIntervalLabel": "回溯时间间隔",
Expand Down

0 comments on commit 49f8243

Please sign in to comment.