Skip to content

Commit

Permalink
[8.x] [ML] Single metric viewer: Explorer chart label prop types fix (e…
Browse files Browse the repository at this point in the history
…lastic#201137) (elastic#201195)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ML] Single metric viewer: Explorer chart label prop types fix
(elastic#201137)](elastic#201137)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Robert
Jaszczurek","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-21T14:01:05Z","message":"[ML]
Single metric viewer: Explorer chart label prop types fix
(elastic#201137)\n\n## Summary\r\n\r\nCurrently, on the dashboards page, if an
explorer charts embeddable is\r\nattached, an error appears in the
console:\r\n![Screenshot 2024-11-21 at 13
06\r\n37](https://github.com/user-attachments/assets/978d254c-d971-46c6-b79d-b912d2fa35ae)\r\n\r\nThis
issue occurs due to a PropTypes typo: `boolean` instead of
`bool`.","sha":"90a9565edefe20c07792976aace70cc5d31b2ab7","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug",":ml","release_note:skip","v9.0.0","Team:ML","backport:version","v8.17.0","v8.18.0"],"title":"[ML]
Single metric viewer: Explorer chart label prop types fix
","number":201137,"url":"https://github.com/elastic/kibana/pull/201137","mergeCommit":{"message":"[ML]
Single metric viewer: Explorer chart label prop types fix
(elastic#201137)\n\n## Summary\r\n\r\nCurrently, on the dashboards page, if an
explorer charts embeddable is\r\nattached, an error appears in the
console:\r\n![Screenshot 2024-11-21 at 13
06\r\n37](https://github.com/user-attachments/assets/978d254c-d971-46c6-b79d-b912d2fa35ae)\r\n\r\nThis
issue occurs due to a PropTypes typo: `boolean` instead of
`bool`.","sha":"90a9565edefe20c07792976aace70cc5d31b2ab7"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201137","number":201137,"mergeCommit":{"message":"[ML]
Single metric viewer: Explorer chart label prop types fix
(elastic#201137)\n\n## Summary\r\n\r\nCurrently, on the dashboards page, if an
explorer charts embeddable is\r\nattached, an error appears in the
console:\r\n![Screenshot 2024-11-21 at 13
06\r\n37](https://github.com/user-attachments/assets/978d254c-d971-46c6-b79d-b912d2fa35ae)\r\n\r\nThis
issue occurs due to a PropTypes typo: `boolean` instead of
`bool`.","sha":"90a9565edefe20c07792976aace70cc5d31b2ab7"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Robert Jaszczurek <[email protected]>
  • Loading branch information
kibanamachine and rbrtj authored Nov 21, 2024
1 parent 52e8b0f commit 29a31f4
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ export function ExplorerChartLabel({
}
ExplorerChartLabel.propTypes = {
detectorLabel: PropTypes.object.isRequired,
isEmbeddable: PropTypes.boolean,
isEmbeddable: PropTypes.bool,
entityFields: PropTypes.arrayOf(ExplorerChartLabelBadge.propTypes.entity),
infoTooltip: PropTypes.object.isRequired,
wrapLabel: PropTypes.bool,
Expand Down

0 comments on commit 29a31f4

Please sign in to comment.