Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[8.16] [Ent Search Plugin] Fix loading initial plugin data, save kbn …
…version in kea, fix connector img version (elastic#199777) (elastic#200528) # Backport This will backport the following commits from `main` to `8.16`: - [[Ent Search Plugin] Fix loading initial plugin data, save kbn version in kea, fix connector img version (elastic#199777)](elastic#199777) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jedr Blaszyk","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-18T10:13:19Z","message":"[Ent Search Plugin] Fix loading initial plugin data, save kbn version in kea, fix connector img version (elastic#199777)\n\n## Summary\r\n\r\nPR is a bugfix to dynamically populate the `version` of the connectors\r\ndocker image shown in the onboarding. It's hardcoded to `8.15.0` now\r\n....\r\n\r\nIdeally we want to backport this to 8.16.1 +\r\n\r\nChanges:\r\n- Given that we are already getting\r\n[kibanaVersion](https://github.com/elastic/kibana/blob/main/x-pack/plugins/enterprise_search/public/applications/index.tsx#L65)\r\nfrom the\r\n[backend](https://github.com/elastic/kibana/blob/main/x-pack/plugins/enterprise_search/public/plugin.ts#L212),\r\nI'm saving the version in `KibanaLogic` reducer and use it to popuale\r\nthe docker image version\r\n- I realised that because of [this\r\nchange](https://github.com/elastic/kibana/commit/664c1a0a08003f82cb88c9b4a51f194fbb42cd84#diff-19a48c92980fd550e48c5e1d4d1f9a2bec4d309909b7cfa693264c92b387fe3dR95)\r\n~10 months ago, we stopped passing plugin data, due to `if\r\n(!this.config.host) return; // No API to call` therefore I removed this\r\nline to fix this. Why I think it's safe to merge?\r\n- It was only added 10 months ago, before things were working without\r\nthis extra if statement\r\n- The backend logic handles the non-existent host: see\r\n[here](https://github.com/elastic/kibana/blob/main/x-pack/plugins/enterprise_search/server/lib/enterprise_search_config_api.ts#L45-L61)\r\n- We are guaranteed that other config fields exist, see [config\r\nschema](https://github.com/elastic/kibana/blob/d276b4899533b0bde2038c7fedfed7c30a74a80b/x-pack/plugins/enterprise_search/server/index.ts#L16-L42)\r\n\r\n<img width=\"1204\" alt=\"Screenshot 2024-11-13 at 10 51 36\"\r\nsrc=\"https://github.com/user-attachments/assets/dbd2395b-00e5-4331-a9be-cb2a87133321\">\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"5d00a0a098930b2292ea7777cd1ee9f46a91a778","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","v9.0.0","v8.17.0","v8.16.1"],"title":"[Ent Search Plugin] Fix loading initial plugin data, save kbn version in kea, fix connector img version","number":199777,"url":"https://github.com/elastic/kibana/pull/199777","mergeCommit":{"message":"[Ent Search Plugin] Fix loading initial plugin data, save kbn version in kea, fix connector img version (elastic#199777)\n\n## Summary\r\n\r\nPR is a bugfix to dynamically populate the `version` of the connectors\r\ndocker image shown in the onboarding. It's hardcoded to `8.15.0` now\r\n....\r\n\r\nIdeally we want to backport this to 8.16.1 +\r\n\r\nChanges:\r\n- Given that we are already getting\r\n[kibanaVersion](https://github.com/elastic/kibana/blob/main/x-pack/plugins/enterprise_search/public/applications/index.tsx#L65)\r\nfrom the\r\n[backend](https://github.com/elastic/kibana/blob/main/x-pack/plugins/enterprise_search/public/plugin.ts#L212),\r\nI'm saving the version in `KibanaLogic` reducer and use it to popuale\r\nthe docker image version\r\n- I realised that because of [this\r\nchange](https://github.com/elastic/kibana/commit/664c1a0a08003f82cb88c9b4a51f194fbb42cd84#diff-19a48c92980fd550e48c5e1d4d1f9a2bec4d309909b7cfa693264c92b387fe3dR95)\r\n~10 months ago, we stopped passing plugin data, due to `if\r\n(!this.config.host) return; // No API to call` therefore I removed this\r\nline to fix this. Why I think it's safe to merge?\r\n- It was only added 10 months ago, before things were working without\r\nthis extra if statement\r\n- The backend logic handles the non-existent host: see\r\n[here](https://github.com/elastic/kibana/blob/main/x-pack/plugins/enterprise_search/server/lib/enterprise_search_config_api.ts#L45-L61)\r\n- We are guaranteed that other config fields exist, see [config\r\nschema](https://github.com/elastic/kibana/blob/d276b4899533b0bde2038c7fedfed7c30a74a80b/x-pack/plugins/enterprise_search/server/index.ts#L16-L42)\r\n\r\n<img width=\"1204\" alt=\"Screenshot 2024-11-13 at 10 51 36\"\r\nsrc=\"https://github.com/user-attachments/assets/dbd2395b-00e5-4331-a9be-cb2a87133321\">\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"5d00a0a098930b2292ea7777cd1ee9f46a91a778"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199777","number":199777,"mergeCommit":{"message":"[Ent Search Plugin] Fix loading initial plugin data, save kbn version in kea, fix connector img version (elastic#199777)\n\n## Summary\r\n\r\nPR is a bugfix to dynamically populate the `version` of the connectors\r\ndocker image shown in the onboarding. It's hardcoded to `8.15.0` now\r\n....\r\n\r\nIdeally we want to backport this to 8.16.1 +\r\n\r\nChanges:\r\n- Given that we are already getting\r\n[kibanaVersion](https://github.com/elastic/kibana/blob/main/x-pack/plugins/enterprise_search/public/applications/index.tsx#L65)\r\nfrom the\r\n[backend](https://github.com/elastic/kibana/blob/main/x-pack/plugins/enterprise_search/public/plugin.ts#L212),\r\nI'm saving the version in `KibanaLogic` reducer and use it to popuale\r\nthe docker image version\r\n- I realised that because of [this\r\nchange](https://github.com/elastic/kibana/commit/664c1a0a08003f82cb88c9b4a51f194fbb42cd84#diff-19a48c92980fd550e48c5e1d4d1f9a2bec4d309909b7cfa693264c92b387fe3dR95)\r\n~10 months ago, we stopped passing plugin data, due to `if\r\n(!this.config.host) return; // No API to call` therefore I removed this\r\nline to fix this. Why I think it's safe to merge?\r\n- It was only added 10 months ago, before things were working without\r\nthis extra if statement\r\n- The backend logic handles the non-existent host: see\r\n[here](https://github.com/elastic/kibana/blob/main/x-pack/plugins/enterprise_search/server/lib/enterprise_search_config_api.ts#L45-L61)\r\n- We are guaranteed that other config fields exist, see [config\r\nschema](https://github.com/elastic/kibana/blob/d276b4899533b0bde2038c7fedfed7c30a74a80b/x-pack/plugins/enterprise_search/server/index.ts#L16-L42)\r\n\r\n<img width=\"1204\" alt=\"Screenshot 2024-11-13 at 10 51 36\"\r\nsrc=\"https://github.com/user-attachments/assets/dbd2395b-00e5-4331-a9be-cb2a87133321\">\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"5d00a0a098930b2292ea7777cd1ee9f46a91a778"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Jedr Blaszyk <[email protected]>
- Loading branch information