Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new extensions configuration #787

Merged
merged 2 commits into from
Sep 27, 2024
Merged

add new extensions configuration #787

merged 2 commits into from
Sep 27, 2024

Conversation

jmazzitelli
Copy link
Contributor

@jmazzitelli jmazzitelli commented Jun 27, 2024 •
edited
Loading

@jmazzitelli jmazzitelli self-assigned this Jun 27, 2024
jshaughn
jshaughn reviewed Jun 27, 2024
View reviewed changes
Copy link
Contributor

@jshaughn jshaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor text changes. Should we go ahead and add an url attribute?

crd-docs/crd/kiali.io_kialis.yaml Outdated Show resolved Hide resolved
crd-docs/crd/kiali.io_kialis.yaml Outdated Show resolved Hide resolved
crd-docs/crd/kiali.io_kialis.yaml Outdated Show resolved Hide resolved
@jmazzitelli
Copy link
Contributor Author

Should we go ahead and add an url attribute?

Let's wait until we think more about how we are going to support external URLs

@jshaughn
Copy link
Contributor

I created an issue for this effort: kiali/kiali#7485

@jshaughn jshaughn mentioned this pull request Jul 17, 2024
Merged
@jmazzitelli jmazzitelli added the requires server PR A PR requires additional changes in the backend code. label Jul 22, 2024
@jmazzitelli jmazzitelli marked this pull request as ready for review September 26, 2024 18:46
jshaughn
jshaughn approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@jshaughn jshaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches KEP, LGTM

@jshaughn jshaughn added the test: molecule Molecule test infrastructure and tests themselves label Sep 26, 2024
@jmazzitelli jmazzitelli merged commit ea12b9d into kiali:master Sep 27, 2024
1 check passed
@jmazzitelli jmazzitelli deleted the skupper-extensions branch September 27, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jshaughn jshaughn jshaughn approved these changes

Assignees

@jmazzitelli jmazzitelli

Labels
requires server PR A PR requires additional changes in the backend code. test: molecule Molecule test infrastructure and tests themselves
Projects
Kiali Sprint 24-13 | Kiali v2.0.0
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmazzitelli @jshaughn