Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump google.golang.org/grpc #241

Merged
merged 1 commit into from
Aug 18, 2024
Merged

Bump google.golang.org/grpc #241

merged 1 commit into from
Aug 18, 2024

Conversation

orelmisan
Copy link
Member

trivy [1] indicates that the checkup uses a vulnerable version of grpc [2].

Bump to a version without known vulnerabilities.

[1] https://github.com/aquasecurity/trivy
[2] GHSA-xr7q-jx4m-x55m

Copy link
Collaborator

@RamLavi RamLavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The go bump PR is merged, you can remove the first commit

trivy [1] indicates that the checkup uses a vulnerable
version of grpc [2].

Bump to a version without known vulnerabilities.

[1] https://github.com/aquasecurity/trivy
[2] GHSA-xr7q-jx4m-x55m

Signed-off-by: Orel Misan <[email protected]>
@orelmisan
Copy link
Member Author

Change: Rebase

@RamLavi
Copy link
Collaborator

RamLavi commented Aug 18, 2024

Passed CI on CNV4.17 cluster:

make test/e2e
podman run --rm \
           --volume /home/ralavi/go/src/github.com/kiagnose/kubevirt-dpdk-checkup:/home/ralavi/go/src/github.com/kiagnose/kubevirt-dpdk-checkup:Z \
           --volume /home/ralavi/Downloads:/root/.kube:Z,ro \
           --workdir /home/ralavi/go/src/github.com/kiagnose/kubevirt-dpdk-checkup \
           -e KUBECONFIG=/root/.kube/bm02-ibm-kubeconfig \
           -e TEST_CHECKUP_IMAGE=quay.io/ramlavi/kubevirt-dpdk-checkup:latest \
           -e TEST_NAMESPACE=dpdk-checkup-ns \
           -e NETWORK_ATTACHMENT_DEFINITION_NAME=dpdk-sriovnetwork \
           -e TRAFFIC_GEN_CONTAINER_DISK_IMAGE=quay.io/kiagnose/kubevirt-dpdk-checkup-traffic-gen:main \
           -e VM_UNDER_TEST_CONTAINER_DISK_IMAGE=quay.io/kiagnose/kubevirt-dpdk-checkup-vm:main \
           docker.io/library/golang:1.22.5 go test ./tests/... -test.v -test.timeout=1h -ginkgo.v -ginkgo.timeout=1h
=== RUN   TestKubevirtDpdkCheckup
Running Suite: KubevirtDpdkCheckup Suite - /home/ralavi/go/src/github.com/kiagnose/kubevirt-dpdk-checkup/tests
==============================================================================================================
Random Seed: 1723966643

Will run 1 of 1 specs
------------------------------
[BeforeSuite] 
/home/ralavi/go/src/github.com/kiagnose/kubevirt-dpdk-checkup/tests/test_suite_test.go:56
[BeforeSuite] PASSED [0.003 seconds]
------------------------------
Execute the checkup Job should complete successfully
/home/ralavi/go/src/github.com/kiagnose/kubevirt-dpdk-checkup/tests/checkup_test.go:83
• [216.142 seconds]
------------------------------

Ran 1 of 1 Specs in 216.145 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestKubevirtDpdkCheckup (216.15s)
PASS
ok  	github.com/kiagnose/kubevirt-dpdk-checkup/tests	216.17

@RamLavi RamLavi closed this Aug 18, 2024
@RamLavi RamLavi reopened this Aug 18, 2024
Copy link
Collaborator

@RamLavi RamLavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@orelmisan orelmisan merged commit 322e1d7 into kiagnose:main Aug 18, 2024
8 checks passed
@orelmisan orelmisan deleted the bump-grpc branch August 18, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants