Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[traffic-gen-in-vm] Move testpmd package #139

Merged
merged 7 commits into from
Jul 18, 2023
Merged

[traffic-gen-in-vm] Move testpmd package #139

merged 7 commits into from
Jul 18, 2023

Conversation

RamLavi
Copy link
Collaborator

@RamLavi RamLavi commented Jul 17, 2023

This PR is moving the testpmd functions to a separate package.

@RamLavi RamLavi mentioned this pull request Jul 17, 2023
Merged
@RamLavi RamLavi force-pushed the traffic-gen-in-vm-move_testpmd_package branch from f9a3cb4 to 32fc67f Compare July 18, 2023 13:03
@RamLavi
executer, testpmd: Change client types to be public
d200a3a 
In order to be able to move the testpmd-console module to a separate
package in later commits, changing the types to be public.

Signed-off-by: Ram Lavi <[email protected]>
@RamLavi
executer, testpmd: Change client name to vmiSerialClient
44a59f2 
The current name "client" is too generic. Changing the client name vmiSerialClient.

Signed-off-by: Ram Lavi <[email protected]>
@RamLavi
testpmd: Move to a new file
3c0d494 
This commit moves code to a new file without changing it.
The new file creates a separation between the testpmd related
and the rest of the executor code, preparing it to be move to
another package in future commits.

Also Adding licence paragraph.

Signed-off-by: Ram Lavi <[email protected]>
@RamLavi
testpmd: Create new TestpmdConsole object
7e16d91 
The executer will create this object and will use the testpmd commands
via this object.

Signed-off-by: Ram Lavi <[email protected]>
@RamLavi
testpmd: Change methods to public
a352c57 
In order to move this file to new package in future commits, Changing
the relevant methods to be public.

Signed-off-by: Ram Lavi <[email protected]>
@RamLavi
testpmd: Simplify names and move to public
76ab480 
Now that the functions and structs belong to the testpmd object, we can
simplify their names.
The StatsIdx enumerations are also move to be public.

Signed-off-by: Ram Lavi <[email protected]>
@RamLavi
testpmd: Move to a new package
fdd877e 
Also change the file name to console.go

Signed-off-by: Ram Lavi <[email protected]>
@RamLavi RamLavi force-pushed the traffic-gen-in-vm-move_testpmd_package branch from 32fc67f to fdd877e Compare July 18, 2023 13:07
@RamLavi
Copy link
Collaborator Author

RamLavi commented Jul 18, 2023 

$  TEST_NAMESPACE=dpdk-checkup-ns-1 NETWORK_ATTACHMENT_DEFINITION_NAME=dpdk-sriovnetwork-ns-1 RUNTIME_CLASS_NAME=performance-profile-1 make TEST_IMAGE=quay.io/ramlavi/kubevirt-dpdk-checkup:latest TRAFFIC_GEN_IMAGE_URL=quay.io/kiagnose/kubevirt-dpdk-checkup-traffic-gen:traffic-gen-in-vm VM_CONTAINER_DISK_IMAGE_URL=quay.io/kiagnose/kubevirt-dpdk-checkup-vm:traffic-gen-in-vm test/e2e
docker run --rm \
           --volume /home/ralavi/go/src/github.com/kiagnose/kubevirt-dpdk-checkup:/home/ralavi/go/src/github.com/kiagnose/kubevirt-dpdk-checkup:Z \
           --volume /home/ralavi/.kube:/root/.kube:Z,ro \
           --workdir /home/ralavi/go/src/github.com/kiagnose/kubevirt-dpdk-checkup \
           -e KUBECONFIG=/root/.kube/kubeconfig \
           -e TEST_IMAGE=quay.io/ramlavi/kubevirt-dpdk-checkup:latest \
           -e TEST_NAMESPACE=dpdk-checkup-ns-1 \
           -e NETWORK_ATTACHMENT_DEFINITION_NAME=dpdk-sriovnetwork-ns-1 \
           -e TRAFFIC_GEN_IMAGE_URL=quay.io/kiagnose/kubevirt-dpdk-checkup-traffic-gen:traffic-gen-in-vm \
           -e VM_CONTAINER_DISK_IMAGE_URL=quay.io/kiagnose/kubevirt-dpdk-checkup-vm:traffic-gen-in-vm \
           docker.io/library/golang:1.20.6 go test ./tests/... -test.v -test.timeout=1h -ginkgo.v -ginkgo.timeout=1h
=== RUN   TestKubevirtDpdkCheckup
Running Suite: KubevirtDpdkCheckup Suite - /home/ralavi/go/src/github.com/kiagnose/kubevirt-dpdk-checkup/tests
==============================================================================================================
Random Seed: 1689685754

Will run 1 of 1 specs
------------------------------
[BeforeSuite] 
/home/ralavi/go/src/github.com/kiagnose/kubevirt-dpdk-checkup/tests/test_suite_test.go:60
[BeforeSuite] PASSED [0.002 seconds]
------------------------------
Execute the checkup Job should complete successfully
/home/ralavi/go/src/github.com/kiagnose/kubevirt-dpdk-checkup/tests/checkup_test.go:79
• [244.407 seconds]
------------------------------

Ran 1 of 1 Specs in 244.409 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestKubevirtDpdkCheckup (244.41s)
PASS
ok  	github.com/kiagnose/kubevirt-dpdk-checkup/tests	244.423s

@orelmisan orelmisan merged commit 43644e3 into kiagnose:traffic-gen-in-vm Jul 18, 2023
4 checks passed
@orelmisan orelmisan mentioned this pull request Jul 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orelmisan orelmisan orelmisan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RamLavi @orelmisan