-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[traffic-gen-in-vm] Move testpmd package #139
Merged
orelmisan
merged 7 commits into
kiagnose:traffic-gen-in-vm
from
RamLavi:traffic-gen-in-vm-move_testpmd_package
Jul 18, 2023
Merged
[traffic-gen-in-vm] Move testpmd package #139
orelmisan
merged 7 commits into
kiagnose:traffic-gen-in-vm
from
RamLavi:traffic-gen-in-vm-move_testpmd_package
Jul 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RamLavi
force-pushed
the
traffic-gen-in-vm-move_testpmd_package
branch
from
July 18, 2023 13:03
f9a3cb4
to
32fc67f
Compare
In order to be able to move the testpmd-console module to a separate package in later commits, changing the types to be public. Signed-off-by: Ram Lavi <[email protected]>
The current name "client" is too generic. Changing the client name vmiSerialClient. Signed-off-by: Ram Lavi <[email protected]>
This commit moves code to a new file without changing it. The new file creates a separation between the testpmd related and the rest of the executor code, preparing it to be move to another package in future commits. Also Adding licence paragraph. Signed-off-by: Ram Lavi <[email protected]>
The executer will create this object and will use the testpmd commands via this object. Signed-off-by: Ram Lavi <[email protected]>
In order to move this file to new package in future commits, Changing the relevant methods to be public. Signed-off-by: Ram Lavi <[email protected]>
Now that the functions and structs belong to the testpmd object, we can simplify their names. The StatsIdx enumerations are also move to be public. Signed-off-by: Ram Lavi <[email protected]>
Also change the file name to console.go Signed-off-by: Ram Lavi <[email protected]>
RamLavi
force-pushed
the
traffic-gen-in-vm-move_testpmd_package
branch
from
July 18, 2023 13:07
32fc67f
to
fdd877e
Compare
orelmisan
approved these changes
Jul 18, 2023
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is moving the testpmd functions to a separate package.