[traffic-gen-in-vm] Config: remove trafficGeneratorRuntimeClassName #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RamLavi
changed the title
Following the removal of the traffic-gen pod, there is no longer a need for the `trafficGeneratorRuntimeClassName` configuration parameter. Signed-off-by: Orel Misan <[email protected]>
Following the removal of the `trafficGeneratorRuntimeClassName` configuration parameter, there is no more need to define it in the E2E tests. Also remove the option to get it as an environment variable from the Makefile. Signed-off-by: Orel Misan <[email protected]>
orelmisan
force-pushed
the
config_remove_runtimeclass
branch
from
90a6cef
to
798d220
Compare
|
Change: Rebase |
|
E2E tests passed after the rebase. |
orelmisan
added a commit
to orelmisan/kubevirt-dpdk-checkup
that referenced
this pull request
Jul 11, 2023
Following PR kiagnose#121, the RuntimeClass input parameter was remove. Remove it from the README as well. Signed-off-by: Orel Misan <[email protected]>
orelmisan
added a commit
to orelmisan/kubevirt-dpdk-checkup
that referenced
this pull request
Jul 11, 2023
Following PR kiagnose#121, the RuntimeClass input parameter was removed. Remove it from the README as well. Signed-off-by: Orel Misan <[email protected]>
orelmisan
added a commit
to orelmisan/kubevirt-dpdk-checkup
that referenced
this pull request
Jul 25, 2023
Following PR kiagnose#121, the RuntimeClass input parameter was removed. Remove it from the README as well. Signed-off-by: Orel Misan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the removal of the traffic generator pod, there is no longer a need to have the
trafficGeneratorRuntimeClassNamein the user-supplied configuration.Remove it from:
Tested against an OpenShift Virtualization 4.14 cluster.
Depends on PR #119, please review only the last two commits.