Fix memory leak by freeing owned image bytes after reading barcode

khoren93 · Jun 4, 2024 · e187556 · e187556
1 parent 0ba8b45
commit e187556
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/src/native_zxing.cpp b/src/native_zxing.cpp
@@ -202,6 +202,9 @@ CodeResult _readBarcode(const DecodeBarcodeParams& params) noexcept
  ReaderOptions hints = createReaderOptions(params);
  Result result = ReadBarcode(image, hints);
 
+ // Dart passes us an owned image bytes pointer; we need to free it after
+ delete[] params.bytes;
+
  int duration = elapsed_ms(start);
  platform_log("Read Barcode in: %d ms\n", duration);
  return codeResultFromResult(result, duration, params.width, params.height);
@@ -227,6 +230,9 @@ CodeResults _readBarcodes(const DecodeBarcodeParams& params) noexcept
  ReaderOptions hints = createReaderOptions(params);
  Results results = ReadBarcodes(image, hints);
 
+ // Dart passes us an owned image bytes pointer; we need to free it after
+ delete[] params.bytes;
+
  int duration = elapsed_ms(start);
  platform_log("Read Barcode in: %d ms\n", duration);