DEVPROD-977 Add stepback bisect to project settings page (evergreen-c…

…i#2177)
khelif96 · Dec 21, 2023 · 6d24d2f · 6d24d2f
1 parent cc5b551
commit 6d24d2f
Show file tree

Hide file tree

Showing 10 changed files with 100 additions and 0 deletions.
diff --git a/cypress/integration/projectSettings/stepback_bisect.ts b/cypress/integration/projectSettings/stepback_bisect.ts
@@ -0,0 +1,61 @@
+import { clickSave } from "../../utils";
+import { getGeneralRoute, project, projectUseRepoEnabled } from "./constants";
+
+describe("Stepback bisect setting", () => {
+  describe("Repo project present", () => {
+    const destination = getGeneralRoute(projectUseRepoEnabled);
+
+    beforeEach(() => {
+      cy.visit(destination);
+    });
+
+    it("Starts as default to repo", () => {
+      cy.dataCy("stepback-bisect-group")
+        .contains("Default to repo")
+        .find("input")
+        .should("have.attr", "aria-checked", "true");
+    });
+
+    it("Clicking on enabled and then save shows a success toast", () => {
+      cy.dataCy("stepback-bisect-group").contains("Enable").click();
+      clickSave();
+      cy.validateToast("success", "Successfully updated project");
+
+      cy.reload();
+
+      cy.dataCy("stepback-bisect-group")
+        .contains("Enable")
+        .find("input")
+        .should("have.attr", "aria-checked", "true");
+    });
+  });
+
+  describe("Repo project not present", () => {
+    const destination = getGeneralRoute(project);
+
+    beforeEach(() => {
+      cy.visit(destination);
+    });
+
+    it("Starts as disabled", () => {
+      cy.dataCy("stepback-bisect-group")
+        .contains("Disable")
+        .find("input")
+        .should("have.attr", "aria-checked", "true");
+    });
+
+    it("Clicking on enabled and then save shows a success toast", () => {
+      cy.dataCy("stepback-bisect-group").contains("Enable").click();
+
+      clickSave();
+      cy.validateToast("success", "Successfully updated project");
+
+      cy.reload();
+
+      cy.dataCy("stepback-bisect-group")
+        .contains("Enable")
+        .find("input")
+        .should("have.attr", "aria-checked", "true");
+    });
+  });
+});
diff --git a/src/gql/fragments/projectSettings/general.graphql b/src/gql/fragments/projectSettings/general.graphql
@@ -12,6 +12,7 @@ fragment ProjectGeneralSettings on Project {
   repo
   repotrackerDisabled
   spawnHostScriptPath
+  stepbackBisect
   stepbackDisabled
   taskSync {
     configEnabled
@@ -32,6 +33,7 @@ fragment RepoGeneralSettings on RepoRef {
   repo
   repotrackerDisabled
   spawnHostScriptPath
+  stepbackBisect
   stepbackDisabled
   taskSync {
     configEnabled

diff --git a/src/gql/generated/types.ts b/src/gql/generated/types.ts
@@ -3459,6 +3459,7 @@ export type ProjectGeneralSettingsFragment = {
   repo: string;
   repotrackerDisabled?: boolean | null;
   spawnHostScriptPath: string;
+  stepbackBisect?: boolean | null;
   stepbackDisabled?: boolean | null;
   versionControlEnabled?: boolean | null;
   taskSync: {
@@ -3481,6 +3482,7 @@ export type RepoGeneralSettingsFragment = {
   repo: string;
   repotrackerDisabled: boolean;
   spawnHostScriptPath: string;
+  stepbackBisect?: boolean | null;
   stepbackDisabled: boolean;
   versionControlEnabled: boolean;
   taskSync: {
@@ -3628,6 +3630,7 @@ export type ProjectSettingsFieldsFragment = {
     repo: string;
     repotrackerDisabled?: boolean | null;
     spawnHostScriptPath: string;
+    stepbackBisect?: boolean | null;
     stepbackDisabled?: boolean | null;
     versionControlEnabled?: boolean | null;
     notifyOnBuildFailure?: boolean | null;
@@ -3834,6 +3837,7 @@ export type RepoSettingsFieldsFragment = {
     repo: string;
     repotrackerDisabled: boolean;
     spawnHostScriptPath: string;
+    stepbackBisect?: boolean | null;
     stepbackDisabled: boolean;
     versionControlEnabled: boolean;
     notifyOnBuildFailure: boolean;
@@ -4235,6 +4239,7 @@ export type ProjectEventSettingsFragment = {
     repo: string;
     repotrackerDisabled?: boolean | null;
     spawnHostScriptPath: string;
+    stepbackBisect?: boolean | null;
     stepbackDisabled?: boolean | null;
     notifyOnBuildFailure?: boolean | null;
     githubTriggerAliases?: Array<string> | null;
@@ -6698,6 +6703,7 @@ export type ProjectEventLogsQuery = {
           repo: string;
           repotrackerDisabled?: boolean | null;
           spawnHostScriptPath: string;
+          stepbackBisect?: boolean | null;
           stepbackDisabled?: boolean | null;
           notifyOnBuildFailure?: boolean | null;
           githubTriggerAliases?: Array<string> | null;
@@ -6910,6 +6916,7 @@ export type ProjectEventLogsQuery = {
           repo: string;
           repotrackerDisabled?: boolean | null;
           spawnHostScriptPath: string;
+          stepbackBisect?: boolean | null;
           stepbackDisabled?: boolean | null;
           notifyOnBuildFailure?: boolean | null;
           githubTriggerAliases?: Array<string> | null;
@@ -7197,6 +7204,7 @@ export type ProjectSettingsQuery = {
       repo: string;
       repotrackerDisabled?: boolean | null;
       spawnHostScriptPath: string;
+      stepbackBisect?: boolean | null;
       stepbackDisabled?: boolean | null;
       versionControlEnabled?: boolean | null;
       notifyOnBuildFailure?: boolean | null;
@@ -7455,6 +7463,7 @@ export type RepoEventLogsQuery = {
           repo: string;
           repotrackerDisabled?: boolean | null;
           spawnHostScriptPath: string;
+          stepbackBisect?: boolean | null;
           stepbackDisabled?: boolean | null;
           notifyOnBuildFailure?: boolean | null;
           githubTriggerAliases?: Array<string> | null;
@@ -7667,6 +7676,7 @@ export type RepoEventLogsQuery = {
           repo: string;
           repotrackerDisabled?: boolean | null;
           spawnHostScriptPath: string;
+          stepbackBisect?: boolean | null;
           stepbackDisabled?: boolean | null;
           notifyOnBuildFailure?: boolean | null;
           githubTriggerAliases?: Array<string> | null;
@@ -7883,6 +7893,7 @@ export type RepoSettingsQuery = {
       repo: string;
       repotrackerDisabled: boolean;
       spawnHostScriptPath: string;
+      stepbackBisect?: boolean | null;
       stepbackDisabled: boolean;
       versionControlEnabled: boolean;
       notifyOnBuildFailure: boolean;

diff --git a/src/pages/projectSettings/CopyProjectModal.test.tsx b/src/pages/projectSettings/CopyProjectModal.test.tsx
@@ -290,6 +290,7 @@ const projectSettingsMock: ApolloMock<
           deactivatePrevious: true,
           repotrackerDisabled: false,
           stepbackDisabled: null,
+          stepbackBisect: null,
           patchingDisabled: false,
           taskSync: {
             configEnabled: false,

diff --git a/src/pages/projectSettings/tabs/EventLogTab/EventLogTab.test.tsx b/src/pages/projectSettings/tabs/EventLogTab/EventLogTab.test.tsx
@@ -100,6 +100,7 @@ const projectEventsQuery: ProjectEventLogsQuery = {
             deactivatePrevious: true,
             repotrackerDisabled: false,
             stepbackDisabled: null,
+            stepbackBisect: null,
             patchingDisabled: false,
             taskSync: {
               configEnabled: false,
@@ -186,6 +187,7 @@ const projectEventsQuery: ProjectEventLogsQuery = {
             deactivatePrevious: true,
             repotrackerDisabled: false,
             stepbackDisabled: null,
+            stepbackBisect: null,
             patchingDisabled: false,
             taskSync: {
               configEnabled: false,

diff --git a/src/pages/projectSettings/tabs/GeneralTab/getFormSchema.tsx b/src/pages/projectSettings/tabs/GeneralTab/getFormSchema.tsx
@@ -165,6 +165,14 @@ export const getFormSchema = (
                   true
                 ),
               },
+              stepbackBisection: {
+                type: ["boolean", "null"],
+                title: "Stepback Bisection",
+                oneOf: radioBoxOptions(
+                  ["Enabled", "Disabled"],
+                  repoData?.projectFlags?.scheduling?.stepbackBisection
+                ),
+              },
               deactivateStepback: {
                 type: "null" as "null",
               },
@@ -342,6 +350,12 @@ export const getFormSchema = (
           "ui:description":
             "Disabling this setting will override all enabled stepback settings for the project. Disabling stepback won't cancel any active stepback tasks, but it will prevent any future ones.",
         },
+        stepbackBisection: {
+          "ui:widget": widgets.RadioBoxWidget,
+          "ui:description":
+            "Bisection will cause your stepback to activate the midway task between the last failing task and last passing task.",
+          "ui:data-cy": "stepback-bisect-group",
+        },
         deactivateStepback: {
           "ui:field": "deactivateStepbackTask",
           "ui:showLabel": false,

diff --git a/src/pages/projectSettings/tabs/GeneralTab/transformers.test.ts b/src/pages/projectSettings/tabs/GeneralTab/transformers.test.ts
@@ -47,6 +47,7 @@ const repoForm: GeneralFormState = {
     scheduling: {
       deactivatePrevious: true,
       stepbackDisabled: true,
+      stepbackBisection: true,
       deactivateStepback: null,
     },
     repotracker: {
@@ -81,6 +82,7 @@ const repoResult: Pick<RepoSettingsInput, "projectRef"> = {
     repotrackerDisabled: false,
     patchingDisabled: false,
     stepbackDisabled: true,
+    stepbackBisect: true,
     taskSync: {
       configEnabled: true,
       patchEnabled: true,
@@ -111,6 +113,7 @@ const projectForm: GeneralFormState = {
     scheduling: {
       deactivatePrevious: null,
       stepbackDisabled: null,
+      stepbackBisection: null,
       deactivateStepback: null,
     },
     repotracker: {
@@ -148,6 +151,7 @@ const projectResult: Pick<ProjectSettingsInput, "projectRef"> = {
     repotrackerDisabled: null,
     patchingDisabled: null,
     stepbackDisabled: null,
+    stepbackBisect: null,
     taskSync: {
       configEnabled: null,
       patchEnabled: null,

diff --git a/src/pages/projectSettings/tabs/GeneralTab/transformers.ts b/src/pages/projectSettings/tabs/GeneralTab/transformers.ts
@@ -41,6 +41,7 @@ export const gqlToForm = ((data, options = {}) => {
       scheduling: {
         deactivatePrevious: projectRef.deactivatePrevious,
         stepbackDisabled: projectRef.stepbackDisabled,
+        stepbackBisection: projectRef.stepbackBisect,
         deactivateStepback: null,
       },
       repotracker: {
@@ -91,6 +92,7 @@ export const formToGql = ((
     deactivatePrevious: projectFlags.scheduling.deactivatePrevious,
     repotrackerDisabled: projectFlags.repotracker.repotrackerDisabled,
     stepbackDisabled: projectFlags.scheduling.stepbackDisabled,
+    stepbackBisect: projectFlags.scheduling.stepbackBisection,
     patchingDisabled: projectFlags.patch.patchingDisabled,
     taskSync: {
       configEnabled: projectFlags.taskSync.configEnabled,

diff --git a/src/pages/projectSettings/tabs/GeneralTab/types.ts b/src/pages/projectSettings/tabs/GeneralTab/types.ts
@@ -22,6 +22,7 @@ export interface GeneralFormState {
     scheduling: {
       deactivatePrevious: boolean | null;
       stepbackDisabled: boolean | null;
+      stepbackBisection: boolean | null;
       deactivateStepback: null;
     };
     repotracker: {

diff --git a/src/pages/projectSettings/tabs/testData.ts b/src/pages/projectSettings/tabs/testData.ts
@@ -46,6 +46,7 @@ const projectBase: ProjectSettingsQuery["projectSettings"] = {
     repotrackerDisabled: null,
     patchingDisabled: null,
     stepbackDisabled: null,
+    stepbackBisect: null,
     taskSync: {
       configEnabled: null,
       patchEnabled: null,
@@ -174,6 +175,7 @@ const repoBase: RepoSettingsQuery["repoSettings"] = {
     notifyOnBuildFailure: false,
     patchingDisabled: false,
     stepbackDisabled: true,
+    stepbackBisect: true,
     taskSync: {
       configEnabled: true,
       patchEnabled: true,