Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow regex from the cli #442

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Allow regex from the cli #442

merged 2 commits into from
Jul 15, 2024

Conversation

pvandyken
Copy link
Contributor

Adds :match and :search as valid filter methods, each of which should
take =VALUE.

Expands error handling to give different error messages for different
filter misspecifications.

@github-actions github-actions bot added the enhancement New feature or request label Jul 13, 2024
@pvandyken pvandyken force-pushed the feat/cli-regex branch 2 times, most recently from 431e950 to 2bb9ba9 Compare July 13, 2024 19:25
Adds :match and :search as valid filter methods, each of which should
take =VALUE.

Expands error handling to give different error messages for different
filter misspecifications.
Copy link

codecov bot commented Jul 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.36%. Comparing base (9fe8023) to head (2d4da35).
Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #442      +/-   ##
==========================================
+ Coverage   94.32%   94.36%   +0.03%     
==========================================
  Files          55       55              
  Lines        2203     2218      +15     
==========================================
+ Hits         2078     2093      +15     
  Misses        125      125              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pvandyken pvandyken merged commit dd3aaf5 into khanlab:main Jul 15, 2024
38 checks passed
@pvandyken pvandyken deleted the feat/cli-regex branch July 15, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant