Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add converters to SnakeBidsApp #421

Merged
merged 2 commits into from
May 9, 2024

Conversation

pvandyken
Copy link
Contributor

@pvandyken pvandyken commented May 1, 2024

strings being passed to the arguments in old apps were breaking. Convert now to Paths

strings being passed to the arguments in old apps were breaking. Convert
now to Paths
@pvandyken pvandyken added the bug Something isn't working label May 1, 2024
Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.50%. Comparing base (ed7dbe6) to head (ad0b495).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #421   +/-   ##
=======================================
  Coverage   94.50%   94.50%           
=======================================
  Files          55       55           
  Lines        2184     2184           
=======================================
  Hits         2064     2064           
  Misses        120      120           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pvandyken pvandyken merged commit 2040263 into khanlab:main May 9, 2024
37 checks passed
@pvandyken pvandyken deleted the fix/SnakeBidsApp-type-regression branch May 9, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant