Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to get working with snakemake>=8.0 #401

Closed
wants to merge 1 commit into from
Closed

Conversation

akhanf
Copy link
Member

@akhanf akhanf commented Apr 9, 2024

Proposed changes

I'm using some snakemake v8 features and plugins so wanted to see if we could update to become compatible with it.
Turns out the required changes seem to be pretty minimal, just a couple things that have been moved around:

  • load_configfile() is now in snakemake.common.configfile instead of snakemake.io
  • main() is now in snakemake.cli instead of snakemake

I also updated the pyproject since snakemake 8 requires at least python 3.11, and removed any version pinning specific to python versions lower than 3.11.

NOTE: Still doesn't pass quality checks (pyright stubs), other typing stuff. My local tests were also intermittently failing, but seemed to be going over the runtime. @pvandyken do you mind having a look at this?

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!

  • Changes have been tested to ensure that fix is effective or that a feature works.
  • Changes pass the unit tests
  • I have included necessary documentation or comments (as necessary)
  • Any dependent changes have been merged and published

The required changes are pretty minimal, just a couple things that have
been moved around.

I also updated the pyproject since snakemake 8 requires at least python
3.11.

NOTE: Still doesn't pass quality checks (pyright stubs), other typing stuff. My local tests were also intermittently failing, but seemed to be going over the runtime.
@pvandyken
Copy link
Contributor

Thanks for going over this. I was waiting until #362 was merged as I think it overlaps with this and I wanted to save doing it twice. But I haven't had time... on my list of things to do next week when back from vacation. Can this wait till then (just use a local branch in the meantime)?

@pvandyken
Copy link
Contributor

I also don't want to pin to 3.11 yet. There's a few issues that need to be worked around but I've more or less worked out a plan that will let us keep our version support intact. Obviously have to try it yet

@akhanf
Copy link
Member Author

akhanf commented Apr 9, 2024

Yep, no worries! I also figured this might be best merged after the major update.. Yes would be great if we didn't have to pin to 3.11!

@pvandyken
Copy link
Contributor

Closed for #406

@pvandyken pvandyken closed this Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants