Updates to get working with snakemake>=8.0 #401
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
I'm using some snakemake v8 features and plugins so wanted to see if we could update to become compatible with it.
Turns out the required changes seem to be pretty minimal, just a couple things that have been moved around:
I also updated the pyproject since snakemake 8 requires at least python 3.11, and removed any version pinning specific to python versions lower than 3.11.
NOTE: Still doesn't pass quality checks (pyright stubs), other typing stuff. My local tests were also intermittently failing, but seemed to be going over the runtime. @pvandyken do you mind having a look at this?
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!