Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs template so that it builds #392

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Conversation

pvandyken
Copy link
Contributor

Doesn't address the compute canada specific instructions, which need to be made more generic, but the docs will at least build now

Resolve #391

Copy link

codecov bot commented Feb 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.03%. Comparing base (d3f1d74) to head (aa9f2c0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #392   +/-   ##
=======================================
  Coverage   92.03%   92.03%           
=======================================
  Files          40       40           
  Lines        1770     1770           
=======================================
  Hits         1629     1629           
  Misses        141      141           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kaitj kaitj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm - can always address the CC portion of the docs in a separate PR

@pvandyken pvandyken merged commit c45b129 into khanlab:main Feb 26, 2024
37 checks passed
@pvandyken pvandyken deleted the fix/docs branch February 26, 2024 14:48
@pvandyken pvandyken added the bug Something isn't working label Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation stub has numerous problems
2 participants