Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependabot config #385

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Conversation

kaitj
Copy link
Contributor

@kaitj kaitj commented Feb 21, 2024

Proposed changes

Realised dependabot is only updating workflows found in .github and .github/workflows. This updates the config to also capture the action found in .github/actions/build-test-container. Additionally adds a prefix to the PR title to differentiate PRs for each group.

Note: Will need to separately add any subdirectories for workflows not found in the .github or .github/workflows directories. At the moment, the dependabot config does not accept wildcards or multiple inputs for the directory key.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!

  • Changes have been tested to ensure that fix is effective or that a feature works.
  • Changes pass the unit tests
  • I have included necessary documentation or comments (as necessary)
  • Any dependent changes have been merged and published

Notes

All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.

Add sub-directory within actions to update workflows found there.

Note: Will need to separately add any subdirectories for workflows not
found in the `.github` or `.github/workflows` directories. At the
moment, the dependabot config does not accept wildcards or multiple
inputs for the directory key.
@kaitj kaitj added the skip_changelog Changes to the repository that should not be documented in the CHANGELOG label Feb 21, 2024
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eb2909c) 92.03% compared to head (c57066d) 92.03%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #385   +/-   ##
=======================================
  Coverage   92.03%   92.03%           
=======================================
  Files          40       40           
  Lines        1770     1770           
=======================================
  Hits         1629     1629           
  Misses        141      141           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pvandyken
Copy link
Contributor

I guess they can't be done in one action?

@kaitj
Copy link
Contributor Author

kaitj commented Feb 21, 2024

Unfortunately not. There have been a few requests since 2019 for them to implement either recursive searching or wildcards, but at the moment, this is still the only solution (e.g. multiple package-ecosystems specifying specific directories).

@kaitj kaitj merged commit d88e333 into khanlab:main Feb 21, 2024
37 checks passed
@kaitj kaitj deleted the maint/dependabot-config-update branch February 21, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip_changelog Changes to the repository that should not be documented in the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants