Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependabot config #383

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Add dependabot config #383

merged 1 commit into from
Feb 21, 2024

Conversation

kaitj
Copy link
Contributor

@kaitj kaitj commented Feb 21, 2024

Proposed changes

Noted there were still some workflow using old versions (e.g. actions/checkout@v3). Setup dependabot config for automatically updating github actions versions and added a skip_changelog label to it in order to leave update of github actions out of the release notes. This should make managing the actions versions a little bit easier given the number of workflows we have.

We can consider adding adding the ability to update poetry dependencies to this as well, but I'm not entirely sure how that works. I think it may constrain it to the versions specified by the pyproject.toml, but can look into this more in a future PR if we want to go down this road.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!

  • Changes have been tested to ensure that fix is effective or that a feature works.
  • Changes pass the unit tests
  • I have included necessary documentation or comments (as necessary)
  • Any dependent changes have been merged and published

Notes

All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.

Setup dependabot config for automatically updating github actions
versions. Added a `skip_changelog` label to it in order to leave update
of github actions out of the release notes.
@kaitj kaitj added the skip_changelog Changes to the repository that should not be documented in the CHANGELOG label Feb 21, 2024
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (35cc8e0) 92.03% compared to head (65c774c) 92.03%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #383   +/-   ##
=======================================
  Coverage   92.03%   92.03%           
=======================================
  Files          40       40           
  Lines        1770     1770           
=======================================
  Hits         1629     1629           
  Misses        141      141           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pvandyken
Copy link
Contributor

I do periodically check the poetry deps, there's a simple command to do so, so I don't see that as a big deal.

This is nice though, I had started to try this before and got intimidated

@kaitj kaitj merged commit e786f78 into khanlab:main Feb 21, 2024
37 checks passed
@kaitj kaitj deleted the maint/actions-update branch February 21, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip_changelog Changes to the repository that should not be documented in the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants