Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent custom entities from drawing standard ent #382

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

pvandyken
Copy link
Contributor

A failing test drew "ce" by chance, which is a valid entity name

A failing test drew "ce" be chance, which is a valid entity name
@pvandyken pvandyken added the bug Something isn't working label Feb 20, 2024
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (35cc8e0) 92.03% compared to head (082a15e) 92.03%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #382   +/-   ##
=======================================
  Coverage   92.03%   92.03%           
=======================================
  Files          40       40           
  Lines        1770     1770           
=======================================
  Hits         1629     1629           
  Misses        141      141           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kaitj kaitj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lgtm - almost missed the added not in (... | set(std_entities)) in custom_ents.

@pvandyken
Copy link
Contributor Author

This lgtm - almost missed the added not in (... | set(std_entities)) in custom_ents.

Ah yes, sorry, I thought it good to refactor that section

@pvandyken pvandyken merged commit 6161825 into khanlab:main Feb 21, 2024
36 checks passed
@pvandyken pvandyken deleted the fix/bids-test-failure branch February 21, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants