Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move codecoverage upload to seperate job #380

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

pvandyken
Copy link
Contributor

My attempt to fix the codecoverage by doing all the code uploading in a separate job after all the testing is done. (followed the blog https://about.codecov.io/blog/uploading-code-coverage-in-a-separate-job-on-github-actions/)

@pvandyken pvandyken added the maintenance Updates or improvements that do not change functionality of the code label Feb 20, 2024
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (35cc8e0) 92.03% compared to head (269e460) 92.03%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #380   +/-   ##
=======================================
  Coverage   92.03%   92.03%           
=======================================
  Files          40       40           
  Lines        1770     1770           
=======================================
  Hits         1629     1629           
  Misses        141      141           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pvandyken
Copy link
Contributor Author

@kaitj, this seems to work well, hopefully it solves the flakiness issues we've been having

@pvandyken pvandyken merged commit c363927 into khanlab:main Feb 21, 2024
37 checks passed
@pvandyken pvandyken deleted the maint/codecov-update branch February 21, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Updates or improvements that do not change functionality of the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants