Update updated spec name, declare spec for tests #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
akhanf,
Bradley-Karat,
kaitj,
mcespedes99 and
myousif9
kaitj
approved these changes
Feb 6, 2024
|
Yeah, I forgot to run the |
pvandyken
force-pushed
the
maint/versioned-bids
branch
from
6cba37c to
fe63e70
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #369 +/- ##
===========================================
+ Coverage 75.21% 91.60% +16.38%
===========================================
Files 39 39
Lines 1727 1727
===========================================
+ Hits 1299 1582 +283
+ Misses 428 145 -283 ☔ View full report in Codecov by Sentry. |
These expose a bug in ruamel round-tripping (not critical for our application)
pvandyken
added
maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small maintenance PR before the next release. This updates the name of the 0_10_1 spec to 0_11_0 to reflect the fact that it will be released in v0.11.0. It also declares a spec in
conftest.pyto silence the numerous warnings now being thrown for the current lack of declaration.