Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude run from test strategy #368

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

pvandyken
Copy link
Contributor

This fixes the failing test on main.

The pybids internal formatting of values as integers caused problems

The pybids internal formatting of values as integers caused problems
@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (998cca2) 91.60% compared to head (e636501) 91.60%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #368   +/-   ##
=======================================
  Coverage   91.60%   91.60%           
=======================================
  Files          39       39           
  Lines        1727     1727           
=======================================
  Hits         1582     1582           
  Misses        145      145           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pvandyken pvandyken added bug Something isn't working skip_changelog Changes to the repository that should not be documented in the CHANGELOG labels Feb 3, 2024
Copy link
Contributor

@kaitj kaitj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

I guess something to note if we want to test the run entity (we might already be elsewhere), is that the bids spec expects this value to be a non-negative integer (hence the pybids expectation).

@pvandyken
Copy link
Contributor Author

I guess something to note if we want to test the run entity (we might already be elsewhere), is that the bids spec expects this value to be a non-negative integer (hence the pybids expectation).

The issue is more that pybids converts it into an integer internally, rather than simply validating and storing as a string. This prevents us from using it in any test requiring interconversion between path and layout.

@pvandyken pvandyken merged commit f7db3c5 into khanlab:main Feb 5, 2024
34 checks passed
@pvandyken pvandyken deleted the fix/failing-filter-test branch February 5, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working skip_changelog Changes to the repository that should not be documented in the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants