Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding argument for metadata indexing by generate_inputs #367

Merged
merged 11 commits into from
Feb 2, 2024

Conversation

myousif9
Copy link
Contributor

Adding argument for metadata indexing with pybids in generate_inputs function which allows metadata to be accessible in BIDSLayout returned from <generate_inputs_return>.layout.

Copy link
Contributor

@pvandyken pvandyken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The repo will need to be formatted with ruff, poetry run poe fix should do the trick.

Otherwise, looks good

Copy link
Contributor

@kaitj kaitj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me pending running the formatting on this. Also wondering about the additional imports - I don't see where it gets used in the diff.

snakebids/tests/test_generate_inputs.py Outdated Show resolved Hide resolved
@pvandyken
Copy link
Contributor

@myousif9 feel free to add an ignore comment to the ruff error you're getting

@myousif9
Copy link
Contributor Author

myousif9 commented Feb 1, 2024

Ran ruff formatting.

@myousif9 myousif9 requested review from kaitj and pvandyken February 1, 2024 17:23
@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5acabfd) 91.60% compared to head (f519596) 91.60%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #367   +/-   ##
=======================================
  Coverage   91.60%   91.60%           
=======================================
  Files          39       39           
  Lines        1727     1727           
=======================================
  Hits         1582     1582           
  Misses        145      145           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@myousif9
Copy link
Contributor Author

myousif9 commented Feb 1, 2024

Added ignore comment for ruff error, synced with main branch and now passes all checks.

@pvandyken pvandyken merged commit 998cca2 into khanlab:main Feb 2, 2024
34 checks passed
@pvandyken pvandyken added the enhancement New feature or request label Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants