-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding argument for metadata indexing by generate_inputs #367
Conversation
Encode ordered dicts as regular dicts with ruamel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The repo will need to be formatted with ruff
, poetry run poe fix
should do the trick.
Otherwise, looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me pending running the formatting on this. Also wondering about the additional imports - I don't see where it gets used in the diff.
@myousif9 feel free to add an ignore comment to the ruff error you're getting |
Ran ruff formatting. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #367 +/- ##
=======================================
Coverage 91.60% 91.60%
=======================================
Files 39 39
Lines 1727 1727
=======================================
Hits 1582 1582
Misses 145 145 ☔ View full report in Codecov by Sentry. |
Added ignore comment for ruff error, synced with main branch and now passes all checks. |
Adding argument for metadata indexing with pybids in
generate_inputs
function which allows metadata to be accessible inBIDSLayout
returned from<generate_inputs_return>.layout
.