-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mechanism for regex filtering #365
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Largely looks good to me, some comments on some of the code comments and docstring.
b5187df
to
f1869bd
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #365 +/- ##
==========================================
+ Coverage 90.63% 91.24% +0.60%
==========================================
Files 32 33 +1
Lines 1495 1564 +69
==========================================
+ Hits 1355 1427 +72
+ Misses 140 137 -3 ☔ View full report in Codecov by Sentry. |
Filters can now take a subkey: `match` or `search`, which will change the matching method from the default direct match to a python regex method.
76b33db
to
8a8e06f
Compare
Filters can now take a subkey:
match
orsearch
, which will change the matching method from the default direct match to a python regex method.