Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mechanism for regex filtering #365

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

pvandyken
Copy link
Contributor

Filters can now take a subkey: match or search, which will change the matching method from the default direct match to a python regex method.

Copy link
Contributor

@kaitj kaitj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Largely looks good to me, some comments on some of the code comments and docstring.

snakebids/core/_querying.py Outdated Show resolved Hide resolved
snakebids/core/input_generation.py Outdated Show resolved Hide resolved
snakebids/core/input_generation.py Outdated Show resolved Hide resolved
snakebids/core/input_generation.py Outdated Show resolved Hide resolved
snakebids/core/input_generation.py Outdated Show resolved Hide resolved
@pvandyken pvandyken requested a review from kaitj January 24, 2024 01:34
@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (e4586e1) 90.63% compared to head (76b33db) 91.24%.
Report is 27 commits behind head on main.

❗ Current head 76b33db differs from pull request most recent head 8a8e06f. Consider uploading reports for the commit 8a8e06f to get more accurate results

Files Patch % Lines
snakebids/core/input_generation.py 95.74% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #365      +/-   ##
==========================================
+ Coverage   90.63%   91.24%   +0.60%     
==========================================
  Files          32       33       +1     
  Lines        1495     1564      +69     
==========================================
+ Hits         1355     1427      +72     
+ Misses        140      137       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Filters can now take a subkey: `match` or `search`, which will change
the matching method from the default direct match to a python regex
method.
@pvandyken pvandyken merged commit 5acabfd into khanlab:main Feb 1, 2024
34 checks passed
@pvandyken pvandyken deleted the feat/regex-filters branch February 1, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants