Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add testing for Python 3.12 #361

Merged
merged 3 commits into from
Jan 11, 2024
Merged

Add testing for Python 3.12 #361

merged 3 commits into from
Jan 11, 2024

Conversation

pvandyken
Copy link
Contributor

@pvandyken pvandyken commented Dec 21, 2023 •
edited
Loading

Also caps snakemake below 8.0 until we can build compatibility (major breaking api changes in that release)

A small fix in the comparison logic in ImmutableList

@pvandyken pvandyken changed the title Add testing for 3.12 Add testing for Python 3.12 Dec 21, 2023
@pvandyken pvandyken marked this pull request as ready for review December 21, 2023 17:14
@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9898fd5) 88.88% compared to head (39894cc) 89.14%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #361      +/-   ##
==========================================
+ Coverage   88.88%   89.14%   +0.26%     
==========================================
  Files          30       30              
  Lines        1475     1465      -10     
==========================================
- Hits         1311     1306       -5     
+ Misses        164      159       -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaitj
Copy link
Contributor

kaitj commented Dec 21, 2023

Code-wise this looks good to me, I'm not sure what is happening with the test there failing for one of the splits though.

@pvandyken
Copy link
Contributor Author

Code-wise this looks good to me, I'm not sure what is happening with the test there failing for one of the splits though.

I have to restrict snakemake to <8.0 in the code (at least I'm pretty sure that's the problem...)

@pvandyken
Copy link
Contributor Author

Also, never added 3.12 to the test matrix!

@kaitj
Copy link
Contributor

kaitj commented Dec 22, 2023

Also, never added 3.12 to the test matrix!

Ahh, thought you did - saw the 3.12 in the strategy matrix there. I assumed the check wasn't testing 3.12 because it was pulling the workflow from main, but I probably should have checked that.

@github-actions github-actions bot requested a review from kaitj January 11, 2024 16:55
@pvandyken
Fix ImmutableList comparisons
de92e23
@pvandyken
Add testing for 3.12
90afdf7 
Cap snakemake below 8.0 until we can build compatibility
@pvandyken
Add py312 support to template and drop pdm testing
39894cc 
pdm cannot resolve different dependency versions for different python
versions, and there is no numpy version that can be simultaneously
resolved both to python 3.8 and python 3.12. So the only way to use
support pdm would be to raise the lower limit of our template app, or
have special pdm support.

Users can still use pdm if they wish, but they'll have to work out the
consequences themselves. pdm is removed from printed instructions and
testing
@pvandyken
Copy link
Contributor Author

Had to drop testing of pdm for the template, as it's unable resolve more than two versions of dependencies at the same time. This particularly effects numpy, as there's no numpy version that can be resolved for both python 3.8 and python 3.12. Progress is tracked in this issue

pvandyken
pvandyken commented Jan 11, 2024
View reviewed changes
snakebids/project_template/copier.yaml
@@ -65,7 +65,7 @@ bids_version:
when: false

python_version:
default: ">=3.8,<3.12"
default: ">=3.8,<3.13"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be set to the range as currently set on pypi. Next release we'll need to remember to update this to >=3.8,<4.0

@pvandyken pvandyken merged commit b38d6b2 into khanlab:main Jan 11, 2024
34 checks passed
@pvandyken pvandyken deleted the maint/py312 branch January 11, 2024 22:38
@pvandyken pvandyken added the maintenance Updates or improvements that do not change functionality of the code label Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akhanf akhanf Awaiting requested review from akhanf

@myousif9 myousif9 Awaiting requested review from myousif9

@Bradley-Karat Bradley-Karat Awaiting requested review from Bradley-Karat

@mcespedes99 mcespedes99 Awaiting requested review from mcespedes99

@kaitj kaitj Awaiting requested review from kaitj

Assignees

@pvandyken pvandyken

Labels
maintenance Updates or improvements that do not change functionality of the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pvandyken @codecov-commenter @kaitj