Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage #356

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Add test coverage #356

merged 1 commit into from
Dec 19, 2023

Conversation

pvandyken
Copy link
Contributor

As per the title!

@pvandyken pvandyken added the maintenance Updates or improvements that do not change functionality of the code label Dec 16, 2023
Copy link

codecov bot commented Dec 16, 2023

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@pvandyken pvandyken force-pushed the maint/ci/coverage branch 2 times, most recently from 306f27d to 8fb4124 Compare December 18, 2023 16:49
Configure future PRs to require an equal or greater level of test
coverage than previous
@pvandyken pvandyken marked this pull request as ready for review December 18, 2023 16:50
@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

Copy link
Contributor

@kaitj kaitj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one largely looks good to me - I am wondering if there is a benefit to setting a minimum target vs having it set to auto. Something we can revisit in the future too.

@pvandyken
Copy link
Contributor Author

This one largely looks good to me - I am wondering if there is a benefit to setting a minimum target vs having it set to auto. Something we can revisit in the future too.

I know the current coverage is above 90%, which I'm fine with. Auto will make sure we don't go below that (it just ensures coverage never decreases). A limit would let the coverage decrease so long as it never goes below the limit. So if maintaining test coverage will be too much of a burden with future PRs, a threshold might be better, but I would say snakebids is at a maturity point where every new feature should be tested.

@pvandyken pvandyken merged commit d7a2a7b into khanlab:main Dec 19, 2023
28 checks passed
@pvandyken pvandyken deleted the maint/ci/coverage branch December 19, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Updates or improvements that do not change functionality of the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants