Fix formatting of empty zip lists #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty zip lists (meaning zip lists with entities but without any values) gave an IndexError when attempting formatting. This fixes the problem, plus refactors the formatting code. In particular, the function to find the elision has been refactored to work only on the 'values' portion of the table to reduce the amount of 'magic numbers', previously needed to account for the table keys Resolves khanlab#339
kaitj
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
Took me a little bit to wrap my head around https://github.com/akhanf/snakebids/blob/b8f78980481904263832ab9e2fa0eedb7e9d3829/snakebids/io/printing.py#L27-L28 and the subsequent code, but looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty zip lists (meaning zip lists with entities but without any values) gave an
IndexErrorwhen attempting formatting. This fixes the problem, plus refactors the formatting code. In particular, the function to find the elision has been refactored to work only on the 'values' portion of the table to reduce the amount of 'magic numbers', previously needed to account for the table keysResolves #339