Preserve order of entries in expand method #348
Conversation
.expand() in all three Expandables was using `set()` to deduplicate paths following expansion. This was altering the order of the paths, preventing predicatable expansion This fix uses `dict.fromkeys` to deduplicate while preserving order Resolves khanlab#346
| @@ -2,7 +2,7 @@ | |||
| This type stub file was generated by pyright. | |||
| """ | |||
|
|
|||
| """Miscellaneous layout-related utilities.""" | |||
| from typing import Sequence | |||
There was a problem hiding this comment.
More of a comment here given this was generated by pyright, but we should look to switch use of abstract base classes in the code base to import from collections.abc. I think a number of these are deprecated from the typing module as of py3.9+.
Related - I came across this a while back, which may be helpful in upgrading syntax, etc: https://github.com/asottile/pyupgrade
There was a problem hiding this comment.
ruff handles these upgrades, so I've been letting it handle it. So may plan was to wait until we drop py38 next year, then ruff should inform us of all these deprecations.
There was a problem hiding this comment.
Cool - I didn't know that. Just took a quick look at the ruff source code and it looks like they're using pyupgrade under the hood too.
.expand() in all three Expandables was using
set()to deduplicate paths following expansion. This was altering the order of the paths, preventing predicatable expansionThis fix uses
dict.fromkeysto deduplicate while preserving order