Port forward 0.9.x changes into 0.10.x #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The resolved path was getting overwritten by the args_dict in SnakebidsArgs. This didn't happen previously because the resolved path was saved under a different name than the CLI parameter, but since resolving the names, the CLI parameter name overwrites the resolved name. Fix by changing the order of update_config and the manual setting of the pybids path
Previously a single parser instance was given as default, and this would be shared across all instances of SnakeBidsApp. This created a problem in the test suite: after one test initialized SnakeBidsApp, subsequent tests performing their own initialization would inheret the same parser, causing errors Mitigate the problem by using a factor to generate a unique parser for every SnakeBdisApp instance
In stable builds, readthedocs is not currently fetching git tags, which we need for determining project version. So we're getting unhelpful versions at the top of our project documentation like `0.0.1.devxxx-blahblah`. This is an attempt to fix this by adding some post_checkout steps
Didn't work, and I can't justify spending the time to make it work
Use Myst 7
Poetry 1.6.x has dropped py37 support, so we have to restrain to 1.5.x until we drop our py37 support Fix a long-standing bug in the release-drafter workflow
Pybidsdb values encoded in the config file had their key names changed without warning in snakebids==0.9.0. This caused apps relying on those configuration names to silently fail to read the database With this fix, once again set the keys with parsable sentinal values so that reliant workflows will still work but maintainers will be alerted to the deprecation Resolves khanlab#333
Had `bids_dirs` where it should be `bids_dir`
pvandyken
added
maintenance
kaitj
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the rest of the changes from the
0.9.xbranch brought forward into0.10.xin preparation for release. As these changes were already reviewed in previous PRs, this shouldn't need an extensive review cycle.